947511 - Goggles can't publish, because it can't load publication.js citing a mime type violation

Status: RESOLVED FIXED

(Webmaker Graveyard :: X-Ray Goggles, defect)

Description

[Pomax]

Possibly a CSP or new server config causing goggles to be completely broken =)

Comment 1

[Pomax]

might also be caused by the recent redirect/rerouting for hackasaurus/goggles? Sounds less likely, but an option.

Comment 2

[JP Schneider :jp]

That did indeed recently change.  Potentially as well, some of the localization stuff pushing up goggles and docs transifex files...not sure if a build went out with that in place yet? (cc jbuck)

Comment 3

[JP Schneider :jp]

Though, looking at Jenkins I see it was over 3 days ago that a new package was built for Goggles.

Is anything in Goggles referring back to hackasaurus?

Comment 4

[Ali Al Dallal [:alicoding]]

I don't think that was transifex stuff since this happened to me as well 3 days ago and I clear my cache of my browser and it's fixed. (Chrome)

Comment 5

[Ali Al Dallal [:alicoding]]

I was wrong on the last part since this still happen. Only I need to close Browser console first and try to publish and I can still see the error.

Comment 6

[JP Schneider :jp]

We have rolled back to v1.0.4 and this has resolved the issue.

Per Aali, it was  https://bugzilla.mozilla.org/show_bug.cgi?id=944824  commit id 1e1f1fd9fa30199538a7a38ca7bd78087391a12e to blame

Comment 7

[JP Schneider :jp]

For reference, this is what it looked like:
https://dl.dropboxusercontent.com/u/2273146/Screen%20Shot%202013-12-06%20at%208.41.30%20PM.JPG

Comment 8

[Ali Al Dallal [:alicoding]]

This line to be exact.  app.use(helmet.contentTypeOptions());

Comment 9

[Ali Al Dallal [:alicoding]]

https://github.com/mozilla/goggles.webmaker.org/blob/master/app.js#L58

Comment 10

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/79

Comment 11

[Jon Buckley [:jbuck]]

Comment on attachment 8344126 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/79

r+, just fix up https://github.com/mozilla/goggles.webmaker.org/pull/79/files#r8181548

Comment 12

[Jon Buckley [:jbuck]]

Yep, :aali is spot on. Nice catch!

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/fd66da6163abec7b08c10f85a89e117018c013c2
Fix bug947511 - Add content-type to publication.js