Closed Bug 947575 Opened 11 years ago Closed 11 years ago

Fix IPDL tests on windows

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

Attachments

(1 file)

Patch, v1
3.78 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
Attached patch Patch, v1 — — Splinter Review 
I found some problems in the IPC C++ tests on windows. This patch makes everything happy.
Attachment #8344134 - Flags: review?(benjamin)
Comment on attachment 8344134 [details] [diff] [review]
Patch, v1

The Sleep(10) in TestUrgencyChild::AnswerFinalTest_Hang() is confusing. Doesn't this just swap the windows build failure for a Linux one? Also Windows sleep is in millisecs, while posix sleep is in seconds...
Attachment #8344134 - Flags: review?(benjamin) → review-
Comment on attachment 8344134 [details] [diff] [review]
Patch, v1

No, the Sleep() function is defined for posix in TestUrgency.cpp and it takes care of the units itself.
Attachment #8344134 - Flags: review- → review?(benjamin)
Comment on attachment 8344134 [details] [diff] [review]
Patch, v1

ugh, ok
Attachment #8344134 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/ad0aca1ace4e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: