Closed Bug 947584 Opened 6 years ago Closed 6 years ago

Page Info dialog box shows wrong names for some cipher suites

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file)

See bug 938369. Assuming my patch for bug 938369, this will be fixed automatically when we fix bug 938369.
Comment on attachment 8344150 [details] [diff] [review]
change-cipher-suite-names-psm.patch

Review of attachment 8344150 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming  bug 938369.
Attachment #8344150 - Flags: review?(cviecco) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/31f11525de8e

I made three sets of changes to the patch after it was r+d:

1. I rebased the changes to nsNSSComponent.cpp
2. I added DEFINES['SSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES'] = 'True' to moz.build to disable the deprecated names.
3. I changed nsNSSCallbacks.cpp to use the new (IANA) names, in response to #2 breaking the build.
Target Milestone: mozilla28 → mozilla30
I partially verified that this is fixed by doing this:

1. Go to https://www.paypal.com/
2. Click on the site identity block "PayPal, Inc. (US)"
3. Click the "More Information" button.
4. Go to the "Security" tab of the Page Info dialog box.

Before this patch:
The cipher suite name at the bottom is "SSL_RSA_WITH_RC4_128_SHA".

After this patch:
The cipher suite name at the bottom is "TLS_RSA_WITH_RC4_128_SHA", as expected.
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/31f11525de8e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.