provide a switch to turn off the building of Acccessibility

RESOLVED FIXED in mozilla0.9.4



17 years ago
17 years ago


(Reporter: mozilla, Assigned: mozilla)



Windows 2000

Firefox Tracking Flags

(Not tracked)



(4 attachments)



17 years ago
This is being driven by two factors:

1) There may be builds that do not want to include the building of
accessibility. For instance in a PDA-type device where there is no MSAA
accessibility and they have severly limited space.

2) The fix for bug 77648 has introduced a dependancy on MS Active Template
Libraries ( for windows builds only ) and some people may not want to install
those pieces of the development toolkit. Not to mention we are trying to keep
the codebase as compiler agnostic as possible ( although ATL seems to be
implemented on more than just the MSVC++ compiler -- Borland ).

Comment 1

17 years ago
w95make: Entering Directory 
f:\build\beonex\mozilla\widget\src\windows\expose\ISimpleDOMNode with target 
+++ make: Creating directory: WIN32_O.OBJ
+++ make: Creating DLL: .\WIN32_O.OBJ\ISimpleDOMNodeMarshal.dll
   Creating library .\WIN32_O.OBJ\ISimpleDOMNodeMarshal.lib and object 
    Installing .\WIN32_O.OBJ\ISimpleDOMNodeMarshal.dll into 
NMAKE : fatal error U1077: 'regsvr32' : return code '0x5'

MOZILLA_0_9_2_BRANCH (branch: 1.4.116).

Comment 2

17 years ago
Created attachment 45759 [details] [diff] [review]
what is currently sitting in the beonex tree

Comment 3

17 years ago
Have the switch working on Windows, I will be posting a diff to test on linux in
a little while and testing it when I get into work after lunch. Also need to
test on Mac - mac changes will be included in the diff.
Keywords: access
Priority: -- → P1
Target Milestone: --- → mozilla0.9.4

Comment 4

17 years ago
Created attachment 46078 [details] [diff] [review]
v1.0 patch to turn off Accessiblity - on by default

Comment 5

17 years ago
Accessibility would be on by default, to turn it off either:

1) on windows
  set DISABLE_ACCESSIBLITY=1 in your environment

2) on Linux/unix
  pass --disable-accessibility to whatever it is we pass those switches to ( put
it in you .mozilla )

3) on Mac set ACCESSIBILITY to 0 in a build script file. Not sure which one,
beard showed me it was possible. I figure mac people know where to set such
variables. I need to have one of them test this out.

Comment 6

17 years ago
If accessible requires MFC please honor NO_MFC=1.

Comment 7

17 years ago
as I understand it ATL is not MFC. We *only* require ( until I can hopefully
find a way around it ) 2 ATL headers for Accessibility. So the NO_MFC shouldn't
apply to this code.

The code posted above was written by aaronl, maybe he can talk to that
needing/requiring MFC better than I. I am unsure of wether needing regsvr32
indicates a dependancy on MFC or just on certain windows functionality.

Comment 8

17 years ago
mscott: can you verify that this patch fixes your problem on windows?

- also, there is an additional patch coming for linux -

Comment 9

17 years ago
Created attachment 46140 [details] [diff] [review]
v1.01 -- addition of changes for Linux

Comment 10

17 years ago
r/sr on the Mac parts of the patch

Comment 11

17 years ago
Actually, you should only build the IDL if 'accessible' is on:

+    if ($main::options{accessible}) {
+    }

Comment 12

17 years ago
r=leaf for build system changes, windows and linux.

Comment 13

17 years ago
Created attachment 46171 [details] [diff] [review]
v1.1 of patch including the linux makefile and mac changes

Comment 14

17 years ago


17 years ago
Blocks: 95819

Comment 15

17 years ago
Checked in last night ( thurs 16 aug )
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 16

17 years ago
May God have mercy on us all. The 212 bug spam-o-rama is Now!
QA Contact: aegis → jrgm
You need to log in before you can comment on or make changes to this bug.