Work around bug 946184 for Aurora

VERIFIED FIXED in Firefox 29

Status

()

defect
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla28
Points:
---

Firefox Tracking Flags

(firefox28 disabled, firefox29 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The only thing blocking <input type=number> from being turned on for v28 is bug 946184 (styling using the <input type=number> pseudo-elements is unreliable). I'm looking at it, but since v28 is to be uplifted tomorrow it doesn't look like I will be able to fix that bug in time. We can easily work around this by avoiding the use of the pseudo-elements in the three chrome CSS files that we use them in though. (Note that bug bug 930010 made it so that only chrome can access the pseudo-elements.) We should probably just do that for Aurora and then back the patch for that out after the uplift.
Posted patch patch (obsolete) — Splinter Review
Attachment #8344351 - Flags: review?(roc)
Comment on attachment 8344351 [details] [diff] [review]
patch

bz, roc, can the first person to get to this review? (smaug is fine with this, but wants a layout/style peers review.)
Attachment #8344351 - Flags: review?(bzbarsky)
Comment on attachment 8344351 [details] [diff] [review]
patch

The chane for upbutton/downbutton makes no sense: it's using the same selector.
Attachment #8344351 - Flags: review?(bzbarsky) → review-
Posted patch patchSplinter Review
Err, right. Sorry, only tested for this applied to ::-moz-number-text and then trying to address review comments for other patches in parallel.
Attachment #8344351 - Attachment is obsolete: true
Attachment #8344351 - Flags: review?(roc)
Attachment #8344356 - Flags: review?(bzbarsky)
Comment on attachment 8344356 [details] [diff] [review]
patch

r=me
Attachment #8344356 - Flags: review?(bzbarsky) → review+
Thanks, bz!

https://hg.mozilla.org/mozilla-central/rev/6f6294b469f0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Keywords: verifyme
Removing keyword since this is specific to input type=number, which is disabled in Fx28. Fx29 already contains the fix for bug 946184.
Keywords: verifyme
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.