Closed
Bug 947718
Opened 9 years ago
Closed 9 years ago
Work around bug 946184 for Aurora
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
FIXED
mozilla28
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file, 1 obsolete file)
3.99 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The only thing blocking <input type=number> from being turned on for v28 is bug 946184 (styling using the <input type=number> pseudo-elements is unreliable). I'm looking at it, but since v28 is to be uplifted tomorrow it doesn't look like I will be able to fix that bug in time. We can easily work around this by avoiding the use of the pseudo-elements in the three chrome CSS files that we use them in though. (Note that bug bug 930010 made it so that only chrome can access the pseudo-elements.) We should probably just do that for Aurora and then back the patch for that out after the uplift.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8344351 -
Flags: review?(roc)
![]() |
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8344351 [details] [diff] [review] patch bz, roc, can the first person to get to this review? (smaug is fine with this, but wants a layout/style peers review.)
Attachment #8344351 -
Flags: review?(bzbarsky)
![]() |
||
Comment 3•9 years ago
|
||
Comment on attachment 8344351 [details] [diff] [review] patch The chane for upbutton/downbutton makes no sense: it's using the same selector.
Attachment #8344351 -
Flags: review?(bzbarsky) → review-
![]() |
Assignee | |
Comment 4•9 years ago
|
||
Err, right. Sorry, only tested for this applied to ::-moz-number-text and then trying to address review comments for other patches in parallel.
Attachment #8344351 -
Attachment is obsolete: true
Attachment #8344351 -
Flags: review?(roc)
Attachment #8344356 -
Flags: review?(bzbarsky)
![]() |
||
Comment 5•9 years ago
|
||
Comment on attachment 8344356 [details] [diff] [review] patch r=me
Attachment #8344356 -
Flags: review?(bzbarsky) → review+
![]() |
Assignee | |
Comment 6•9 years ago
|
||
Thanks, bz! https://hg.mozilla.org/mozilla-central/rev/6f6294b469f0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 7•8 years ago
|
||
Removing keyword since this is specific to input type=number, which is disabled in Fx28. Fx29 already contains the fix for bug 946184.
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•