947718 - Work around bug 946184 for Aurora

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Watt [:jwatt]]

The only thing blocking <input type=number> from being turned on for v28 is bug 946184 (styling using the <input type=number> pseudo-elements is unreliable). I'm looking at it, but since v28 is to be uplifted tomorrow it doesn't look like I will be able to fix that bug in time. We can easily work around this by avoiding the use of the pseudo-elements in the three chrome CSS files that we use them in though. (Note that bug bug 930010 made it so that only chrome can access the pseudo-elements.) We should probably just do that for Aurora and then back the patch for that out after the uplift.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8344351 [details] [diff] [review]
patch

bz, roc, can the first person to get to this review? (smaug is fine with this, but wants a layout/style peers review.)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8344351 [details] [diff] [review]
patch

The chane for upbutton/downbutton makes no sense: it's using the same selector.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

Err, right. Sorry, only tested for this applied to ::-moz-number-text and then trying to address review comments for other patches in parallel.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8344356 [details] [diff] [review]
patch

r=me

Comment 6

[Jonathan Watt [:jwatt]]

Thanks, bz!

https://hg.mozilla.org/mozilla-central/rev/6f6294b469f0

Comment 7

[Ioana (away)]

Removing keyword since this is specific to input type=number, which is disabled in Fx28. Fx29 already contains the fix for bug 946184.