enable-xterm-updates no longer works in comm-central parts of the build
RESOLVED
FIXED
in Thunderbird 28.0
Status
People
(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
744 bytes,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
Bug 944558 was a step towards making mozilla-central build with GNU make for Windows. However they slipped in the removal of print-depth-path.sh which is still referenced in comm-central's rules.mk if you use enable-xterm-updates.
|
(Assignee) | |
Comment 1•5 years ago
|
||
Created attachment 8344366 [details] [diff] [review] Proposed patch Just port the one line in question. (Normally I would investigate porting all the GNU make for Windows compatibility patches, but I'd like this particular bit to make it into 28.)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 8344366 [details] [diff] [review] Proposed patch My current policy on porting build patches has been to only port things that are needed to avoid bustages or to fix ccrework, as I expect we can kill the c-c build system entirely in about 1-2 months.
Attachment #8344366 -
Flags: review?(Pidgeot18) → review+
|
|
(Assignee) | |
Comment 3•5 years ago
|
||
Pushed comm-central changeset 07fc1446c1ab. Then, realised that the patch was malformed all along (sorry about that) and pushed comm-central changeset 4abeeaf9eb70.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
||
Target Milestone: --- → Thunderbird 28.0
You need to log in
before you can comment on or make changes to this bug.
Description
•