Closed Bug 947735 Opened 7 years ago Closed 7 years ago

Build modules/libmar/ in unified mode

Categories

(Toolkit :: Application Update, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: unified
Attachment #8344373 - Flags: review?(netzen)
Comment on attachment 8344373 [details] [diff] [review]
Build modules/libmar/ in unified mode

Review of attachment 8344373 [details] [diff] [review]:
-----------------------------------------------------------------

r+ otherwise

::: modules/libmar/src/mar_read.c
@@ +551,3 @@
>                        int *hasAdditionalBlocks,
> +                      uint32_t *offsetAdditionalBlocks,
> +                      uint32_t *numAdditionalBlocks)

Why are these changes being made, is it in response to any warnings? If not I'd rather leave them out.
Attachment #8344373 - Flags: review?(netzen) → review+
(In reply to Brian R. Bondy [:bbondy] from comment #2)
> ::: modules/libmar/src/mar_read.c
> @@ +551,3 @@
> >                        int *hasAdditionalBlocks,
> > +                      uint32_t *offsetAdditionalBlocks,
> > +                      uint32_t *numAdditionalBlocks)
> 
> Why are these changes being made, is it in response to any warnings? If not
> I'd rather leave them out.

The compiler gets mad at us because this function actually doesn't match the signature of the function declared in the header: <http://mxr.mozilla.org/mozilla-central/source/modules/libmar/src/mar_cmdline.h#34>

The way that this currently "works" is that mar_read.c which is the fine that defines this function (mar_read.c) doesn't include mar_cmdline.h, so the compiler currently doesn't know about this incorrect code.  Unifying these files makes the compiler aware of this brokenness and it complains, rightly so.
https://hg.mozilla.org/mozilla-central/rev/6ecda297fb37
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.