947736 - Build modules/libpref/ in unified mode

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[:ehsan akhgari]

Attachment: Build modules/libpref/ in unified mode

Comment 2

[Benjamin Smedberg]

Comment on attachment 8344374 [details] [diff] [review]
Build modules/libpref/ in unified mode

What's up with nsPrefBranch::NotifyObserver returning an nsresult-as-int? That seems weird and there's no comment explaining it.

Comment 3

[:ehsan akhgari]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Comment on attachment 8344374 [details] [diff] [review]
> Build modules/libpref/ in unified mode
> 
> What's up with nsPrefBranch::NotifyObserver returning an nsresult-as-int?
> That seems weird and there's no comment explaining it.

I'm glad you asked.  :-)

We use that function as a callback argument.  We define the type of that argument in two places, one with an nsresult return code, the other with an int return code:

http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/prefapi.h#157
http://mxr.mozilla.org/mozilla-central/source/modules/libpref/public/Preferences.h#29

To make things more fun, as far as I can tell the return code is never used: <http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/Preferences.cpp#164>.  But that doesn't really matter, since we always return NS_OK.  So I just had to pick something and move on, hence the current patch.

If you don't want to accept this patch then it's fine, but please suggest an alternative.  Should I make this return void?

Comment 4

[Benjamin Smedberg]

Yes, returning void seems better than living with conflicting typedefs.

Comment 5

[:ehsan akhgari]

Attachment: Build modules/libpref/ in unified mode; r=bsmedberg

Comment 6

[:ehsan akhgari]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fe4ca46eec8

Comment 7

[:ehsan akhgari]

Backed out because of bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/982196bdc263

Comment 8

[:ehsan akhgari]

I had to edit all of the places which defined a pref callback function.

https://hg.mozilla.org/integration/mozilla-inbound/rev/98be0e9cbc15

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98be0e9cbc15