[WAP Push] Provide data.length instead of dataLength in authInfo and raw wap push data

RESOLVED FIXED in Firefox 28, Firefox OS v1.3

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: chucklee, Assigned: chucklee)

Tracking

unspecified
1.3 C1/1.4 S1(20dec)
All
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

The type of raw data is UInt8Array, which .length will be stripped when sending to gaia by system message.
Previous implementation uses dataLength to pass the length of data, but it's more straightforward to use data.legnth instead.
Created attachment 8344510 [details] [diff] [review]
Assign length of data.
Attachment #8344510 - Flags: review?(vyang)
Comment on attachment 8344510 [details] [diff] [review]
Assign length of data.

Review of attachment 8344510 [details] [diff] [review]:
-----------------------------------------------------------------

Can you also provide some simple test cases for this?
Attachment #8344510 - Flags: review?(vyang) → review+
Created attachment 8345685 [details] [diff] [review]
0002. Test case.

Check length
Attachment #8345685 - Flags: review?(vyang)
Created attachment 8345686 [details] [diff] [review]
0001. Assign length of data.

Add index in commit title.
Attachment #8344510 - Attachment is obsolete: true
Comment on attachment 8345685 [details] [diff] [review]
0002. Test case.

Review of attachment 8345685 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #8345685 - Flags: review?(vyang) → review+
Try : https://tbpl.mozilla.org/?tree=Try&rev=1581043d2805
It is run based on patch of bug 948376, the xpcshell test of wap push should be run.
Try without patch of bug 948376, https://tbpl.mozilla.org/?tree=Try&rev=7eb800d6812d
The xpcshell test of wap push is not run.
Try : https://tbpl.mozilla.org/?tree=Try&rev=7e2ae22d3538
xpcshell test for wap push does run.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1c67095ab18a
https://hg.mozilla.org/mozilla-central/rev/289a0ca7e7d0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Required to solve regression bug 951436.
blocking-b2g: --- → 1.3?
Flags: needinfo?(whuang)
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(whuang)
https://hg.mozilla.org/releases/mozilla-aurora/rev/be03830fb191
https://hg.mozilla.org/releases/mozilla-aurora/rev/03cddae242d5
status-b2g-v1.3: --- → fixed
status-firefox27: --- → wontfix
status-firefox28: --- → fixed
status-firefox29: --- → fixed
status-b2g-v1.3T: --- → fixed
status-b2g-v1.4: --- → fixed
You need to log in before you can comment on or make changes to this bug.