Closed Bug 947814 Opened 11 years ago Closed 11 years ago

[WAP Push] Provide data.length instead of dataLength in authInfo and raw wap push data

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C1/1.4 S1(20dec)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: chucklee, Assigned: chucklee)

References

Details

Attachments

(2 files, 1 obsolete file)

0002. Test case.
1.34 KB, patch
vicamo
: review+
Details | Diff | Splinter Review
0001. Assign length of data.
1.59 KB, patch
Details | Diff | Splinter Review
The type of raw data is UInt8Array, which .length will be stripped when sending to gaia by system message. Previous implementation uses dataLength to pass the length of data, but it's more straightforward to use data.legnth instead.
Comment on attachment 8344510 [details] [diff] [review] Assign length of data. Review of attachment 8344510 [details] [diff] [review]: ----------------------------------------------------------------- Can you also provide some simple test cases for this?
Attachment #8344510 - Flags: review?(vyang) → review+
Add index in commit title.
Attachment #8344510 - Attachment is obsolete: true
Comment on attachment 8345685 [details] [diff] [review] 0002. Test case. Review of attachment 8345685 [details] [diff] [review]: ----------------------------------------------------------------- Thank you :)
Attachment #8345685 - Flags: review?(vyang) → review+
Try : https://tbpl.mozilla.org/?tree=Try&rev=1581043d2805 It is run based on patch of bug 948376, the xpcshell test of wap push should be run.
https://hg.mozilla.org/mozilla-central/rev/1c67095ab18a https://hg.mozilla.org/mozilla-central/rev/289a0ca7e7d0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Required to solve regression bug 951436.
blocking-b2g: --- → 1.3?
Flags: needinfo?(whuang)
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(whuang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: