[music] testing Metadata extraction from audio files

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: onecyrenus, Assigned: hub)

Tracking

unspecified
x86
Mac OS X
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Metadata generation from audio files, currently doesn't have much testing behind it. 

A test suite should be written to verify that the different file types can be read, and metadata is correctly extracted. 

Verifying thumbnail generation, Title..etc..etc

Comment 1

5 years ago
Created attachment 8382817 [details] [review]
Test ID3v2 parsing

I was originally going to land this in bug 841949, but that won't be able to land until 1.5, so here are some tests for now.

In a way, it's purely academic that we have these tests, since I'll fight anyone who tries to change the metadata parsing before 1.5 (I've had bug 841949 in progress for over 7 months, and don't want to do any major de-bitrotting), but tests make people happy. :)

I'll follow this up with Vorbis/MP4 tests once I learn their formats better. Vorbis will probably be next, since I care about it more and am more familiar with it.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED

Comment 2

5 years ago
Comment on attachment 8382817 [details] [review]
Test ID3v2 parsing

David: You've probably already looked at some of this code, since it's the first commit from my ID3 improvement branch. We can land this separately and feel good about ourselves for having more tests! :)
Attachment #8382817 - Flags: review?(dflanagan)

Updated

5 years ago
Flags: in-testsuite?
Comment on attachment 8382817 [details] [review]
Test ID3v2 parsing

Looks good!
Attachment #8382817 - Flags: review?(dflanagan) → review+

Comment 4

5 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/bd329a2fcd5ce44d37fe84340c8bd0be8dcd32a3

Leaving this open for Vorbis and MP4 tests.
Flags: in-testsuite? → in-testsuite+
(Assignee)

Comment 5

4 years ago
I need to have this before I do bug 796305. Do you mind if I take it?
Flags: needinfo?(squibblyflabbetydoo)

Comment 6

4 years ago
Go for it. We do already have tests for mp3 files (ID3v2), but we need ID3v1, Ogg, and MP4 tests to close this.
Flags: needinfo?(squibblyflabbetydoo)
(Assignee)

Comment 7

4 years ago
A right, id3v1. Will get onto these. I just did Ogg (VorbisComment) and M4A (mp4 tags)

See https://github.com/hfiguiere/gaia/tree/bug796305-album-sort
Assignee: squibblyflabbetydoo → hub
(Assignee)

Comment 8

4 years ago
Created attachment 8484381 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23736

Second part
Attachment #8484381 - Flags: review?(squibblyflabbetydoo)

Comment 9

4 years ago
Comment on attachment 8484381 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23736

This looks good, except that I'd like the Ogg stuff and the M4A stuff to be in separate files, since I'll hopefully be adding to those as I improve our metadata support.
Attachment #8484381 - Flags: review?(squibblyflabbetydoo) → review-
(Assignee)

Comment 10

4 years ago
Comment on attachment 8484381 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23736

since I did the requested changes...
Attachment #8484381 - Flags: review- → review?(squibblyflabbetydoo)

Comment 11

4 years ago
Comment on attachment 8484381 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23736

One more small change and then I think this is good to go. See GitHub for my comments. Thanks for working on this!
Attachment #8484381 - Flags: review?(squibblyflabbetydoo) → review-
(Assignee)

Comment 12

4 years ago
Comment on attachment 8484381 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23736

Updated the PR
Attachment #8484381 - Flags: review- → review?(squibblyflabbetydoo)

Comment 13

4 years ago
Comment on attachment 8484381 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23736

r=me once TBPL finishes and is green
Attachment #8484381 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Comment 14

4 years ago
Merged.
https://github.com/mozilla-b2g/gaia/commit/f4ee5d8477261d50c28d9f49ca9dbd8c26f3f5f0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.