Bug 855208 introduced a regression of A foreground video (ex: youtube) can't mute background content channel which is on playing. The improved way of this is to add test case into testAudioChannelService.cpp
Hi Steven, The user impact of this is When user watch the video via browser or youtube app, the background music will not be paused automatically. This behavior is confirmed by Bug 894249.
blocking-b2g: --- → fugu?
Will it impact v1.2 as well?
Reset mPlayableHiddenContentChildID as CONTENT_PROCESS_ID_UNKNOWN to mute any content channel in background if there is any normal channel with video in foreground.
We'll need it for koi?
blocking-b2g: fugu? → koi?
triage: regression on 1.2. koi+
blocking-b2g: koi? → koi+
Comment on attachment 8345210 [details] [diff] [review] bug947856_background_content_and_foreground_normal.patch The unit-test, TestOneVideoNormalChannelAndOneContentChannel(), does not run in main().
(In reply to Steven Yang [:styang] from comment #2) > Will it impact v1.2 as well? Yes, it is. When user watch the video from youtube, the background music can't be paused automatically.
This patch is based on attachment 8345210 [details] [diff] [review]. Rename the test cast to a short one, and add the test cast into main() of the test program.
Attachment #8345788 - Flags: review?(mchen)
Comment on attachment 8345788 [details] [diff] [review] bug947856_background_content_and_foreground_normal.v2.patch Review of attachment 8345788 [details] [diff] [review]: ----------------------------------------------------------------- It looks good to me. Thanks.
Attachment #8345788 - Flags: review?(mchen) → review+
TBPL seems good of attachment 8345788 [details] [diff] [review]: https://tbpl.mozilla.org/?tree=Try&rev=cb66544698c2
Ready for check-in. Add reviewer information in the commit log.
Attachment #8345788 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/17141bcf340a In my queue for b2g26 once it reopens.
You need to log in before you can comment on or make changes to this bug.