947863 - Investigate which sanity checks can be added for the dialer with marionette-js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Etienne Segonzac (:etienne)]

Since most of the dialer code rely on mozTelephony, which is available only to on-device tests [1], we're notoriously bad integration test wise.

That said, we should still be able to cover the simple tab navigation and maybe the keypad without having to modify the dialer code just for the tests.

It's not much, but it could prevent disasters [1] :)

[1] bug 943779

Comment 1

[Anthony Ricaud (:rik)]

Are you saying we should write some marionnette JS tests?

Comment 2

[Etienne Segonzac (:etienne)]

(In reply to Anthony Ricaud (:rik) from comment #1)
> Are you saying we should write some marionnette JS tests?

Yep, see what we can cover without modifying the app with a bunch of b2g-desktop only code.
So probably the basic navigation and maybe the keypad.

Better than nothing, especially since we won't get on-device pre-landing tests run in the foreseeable future.

Comment 3

[:gerard-majax]

Doesn't the emulator has support for emulating SIM card and telephony ?

Comment 4

[Etienne Segonzac (:etienne)]

We don't have any test infrastructure supporting the emulator AFAIK.

Comment 5

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Keypad and navigation tests.

Comment 6

[Etienne Segonzac (:etienne)]

Yay... it's red... (looking)

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8348316 [details]
Gaia PR

clearing the r? until I get this to run properly on travis

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8348316 [details]
Gaia PR

Yay cleaner code and tests reliably passing!

I'll make them run a few times more to make sure we're not adding intermittents but it's ready for review!

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8348316 [details]
Gaia PR

Thanks Etienne! It looks great!

Can we also add:

- A test for the deletion of one number with a single tap in the delete key.
- A test for a long key press in the '0' key.

to the keypad tests, please?

Comment 10

[Etienne Segonzac (:etienne)]

(In reply to Fernando Jiménez Moreno [:ferjm] (use needinfo instead of CC, please) from comment #9)
> Comment on attachment 8348316 [details]
> Gaia PR
> 
> Thanks Etienne! It looks great!
> 
> Can we also add:
> 
> - A test for the deletion of one number with a single tap in the delete key.
> - A test for a long key press in the '0' key.
> 
> to the keypad tests, please?

Yes! on it.

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 8348316 [details]
Gaia PR

updated!

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8348316 [details]
Gaia PR

Thanks!

Comment 13

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/ee5ee9246d9042561a454e041a533eb1778214db