947865 - [Cost Control] Settings are broken and unusable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

STR

0. With a data usage only SIM (i.e, not Vivo, not Venezuela, not Colombia)
1. With the latest in master, make reset-gaia
2. Open Cost Control
3. Pass the FTU

Now, due to bug 945469 it is impossible to pass the FTE  but you can close and reopen the application.

4. Open settings

Expected:
Settings is displayed properly.

Actual:
Settings is displaying a broken drop-down menu and it is unusable.

Comment 1

[Salvador de la Puente González [:salva]]

We need QA in order to see if this is affecting 1.2.

I tested with the latest Usage application in master but I tested it even before landing bug 944718 (commit 091161997bebfc0c2d053339b1c9891c57216920) and it is reproduced as well.

I'm afraid this could be a Gecko issues related with async / defer load modes for scripts in addition to some wrong assumptions we are making on the Gaia side so, we are solving the Gaia side just right now.

What do you think, Jason?

Comment 2

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Please, could you review my code?

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 8344583 [details]
patch v1.0

It is working perfectly now. Wait for Travis before merging.

Thank you Marina!

Comment 4

[Salvador de la Puente González [:salva]]

Travis is green [1] but the tree is still closed.

[1] https://travis-ci.org/mozilla-b2g/gaia/builds/15166080

Comment 5

[Jason Smith [:jsmith]]

I'll get someone to check if this reproduces on 1.2 today.

Comment 6

[gbennett]

Environmental Variables:
Device: Buri 1.2 comRIL
BuildID: 20131209004003
Gaia: f615ae7acb6731d191b3094e10e314bc28359bbb
Gecko: f684b8f159a3
Version: 26.0
Firmware Version: 20131115

This does not repro on the latest 1.2

Comment 7

[gbennett]

This does not repro on the latest 1.3 and 1.2, should a regression window still be found?

Latest 1.3
Environmental Variables:
Device: Buri 1.3 mozRIL
BuildID: 20131209053402
Gaia: 1d45d1dc3201059d5c8f2efdeb92c04576d8e161
Gecko: 9f12a9fab080
Version: 28.0a1
Firmware Version: 20131115

Comment 8

[Jason Smith [:jsmith]]

Probably not. We should find out why we can't reproduce.

Salva - Can you double check this? We can't reproduce this in house.

Comment 9

[Marina Rodríguez [:mai]]

 Master: 012f11bc56c949ad9e9df399c57448a8436d1448

Comment 10

[Salvador de la Puente González [:salva]]

I double checked it and it is reproducible in our builds. Anyway, this bug have a very low risk and improve performance by using lazy load. Please, consider to include in 1.3. What do you think?

Comment 11

[Salvador de la Puente González [:salva]]

Comment on attachment 8344583 [details]
patch v1.0

Despite solving a bug, this patch fixes a wrong assumption about `async` and `defer` load modes and, in addition, improves the performance.

[Bug caused by] (feature/regressing bug #): --
[User impact] if declined: medium (worse performance) to hight (if bug reproduced)
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 12

[Jason Smith [:jsmith]]

(In reply to Salvador de la Puente González [:salva] from comment #10)
> I double checked it and it is reproducible in our builds. Anyway, this bug
> have a very low risk and improve performance by using lazy load. Please,
> consider to include in 1.3. What do you think?

That sounds fine.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8344583 [details]
patch v1.0

In behalf of Salvador, since he is the owner of Cost Control but doesn't appear in the drivers list: a+

Based on comment 11.

Cheers,
F.

Comment 14

[Noemí Freire (:noemi)]

Hi John,

Could you help us with the uplift to v1.3 branch?. Thanks!

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+ regrsesion

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

[v1.3 66ab7aa] Bug 947865 -[Cost Control] Settings are broken and unusable