947867 - Improve Australis' CustomizableUI events

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

Attachment: changes-for-documentation-scrutiny

(In reply to :Gijs Kruitbosch from bug 942393 comment #8)
> Created attachment 8343953 [details] [diff] [review]
> fix issues with events in Australis' CustomizableUI discovered when
> documenting,
> 
> So, I noticed a few things while documenting. One, onWidgetReset and
> onAreaReset will fire for each buildArea, so they should be passing around
> DOM nodes, not generic widget/area IDs, which won't tell consumers what's
> going on. Second, onWidgetBefore/AfterDOMChange events fired through
> CustomizableUI's onWidgetRemoved should pass the node's actual container,
> and use that when removing the node. For the overflowable toolbar, that will
> *not* be the area's customizationTarget, so I think the current code is
> buggy, and I fixed it. Jared, do these make sense?

(In reply to Jared Wein [:jaws] from bug 942393 comment #9)
> Comment on attachment 8343953 [details] [diff] [review]
> fix issues with events in Australis' CustomizableUI discovered when
> documenting,
> 
> Review of attachment 8343953 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> These should probably be pulled out to a separate bug which will be easier
> to track in the future.
> 
> ::: browser/components/customizableui/src/CustomizableWidgets.jsm
> @@ +813,5 @@
> >      }
> >    });
> >  }
> >  #endif
> > +#endif
> 
> Thanks for adding a newline here.

Carrying over r+

Comment 1

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/f388346b5fae

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f388346b5fae