Closed
Bug 947910
Opened 11 years ago
Closed 11 years ago
Relax the MOZ_ASSERT(mPosition <= mDuration) in case of looping, in AudioBufferSourceNode::CopyFromBufferWithResampling.
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(1 file)
mPosition being a virtual index in the input buffer, it can very well be greater than mDuration, since it is modulo (mLoopEnd - mLoopStart).
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8344625 -
Flags: review?(karlt)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8344625 [details] [diff] [review]
Relax the MOZ_ASSERT(mPosition <= mDuration) in case of looping, in AudioBufferSourceNode::CopyFromBufferWithResampling. r=
r+ on the change to CopyFromInputBufferWithResampling(), thank you, but not the change to the constructor :)
Attachment #8344625 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Oops, yep, I didn't meant to change the constructor like that :-)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4f47c91c65
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•