947910 - Relax the MOZ_ASSERT(mPosition <= mDuration) in case of looping, in AudioBufferSourceNode::CopyFromBufferWithResampling.

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Paul Adenot (:padenot)]

mPosition being a virtual index in the input buffer, it can very well be greater than mDuration, since it is modulo (mLoopEnd - mLoopStart).

Comment 1

[Paul Adenot (:padenot)]

Attachment: Relax the MOZ_ASSERT(mPosition <= mDuration) in case of looping, in AudioBufferSourceNode::CopyFromBufferWithResampling. r=

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8344625 [details] [diff] [review]
Relax the MOZ_ASSERT(mPosition <= mDuration) in case of looping, in AudioBufferSourceNode::CopyFromBufferWithResampling. r=

r+ on the change to CopyFromInputBufferWithResampling(), thank you, but not the change to the constructor :)

Comment 3

[Paul Adenot (:padenot)]

Oops, yep, I didn't meant to change the constructor like that :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4f47c91c65

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d4f47c91c65