947915 - [Australis] When placed on glass Sync button has wrong (dummy) icon while syncing

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Thomas Stache]

Attachment: screenshot of syncing/default button states

During syncing the "Sync" toolbar button shows the wrong icon (the dummy fallback icon).

Related: bug 940844, bug 940046.

Comment 2

[:Gijs (he/him)]

I agree these are different issues, so I'm unduping. This is about the glass selector overriding the 'busy' selector in the tabstoolbar on win7/8. The other bug is about the menu panel not having a high-quality icon for busy state.

Comment 3

[:Gijs (he/him)]

Attachment: fix sync button pending state on Australis win7 glass on menubar/tabstoolbar,

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8366876 [details] [diff] [review]
fix sync button pending state on Australis win7 glass on menubar/tabstoolbar,

Review of attachment 8366876 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 5

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/35f758e7ac6a

With [cui-areatype="toolbar"] because I realized that otherwise this would break things in the menu panel...

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35f758e7ac6a

Comment 7

[Andrei Vaida [:avaida]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:30.0) Gecko/20100101 Firefox/30.0

Issue verified fixed on Windows 7 64-bit using:
- the latest Aurora (Build ID: 20140310004003),
- the latest Nightly (Build ID: 20140310030201).

Comment 8

[Thomas Stache]

Steven, is the correct icon used for the active Sync button? It looks like the normal state has a new icon, which has more slanted arrow ends, while the animated version has the old straight ends.

Comment 9

[Stephen Horlander [:shorlander]]

(In reply to Thomas Stache from comment #8)
> Steven, is the correct icon used for the active Sync button? It looks like
> the normal state has a new icon, which has more slanted arrow ends, while
> the animated version has the old straight ends.

We are updating them all for consistency. New Sync throbbers will be implemented in bug 940844. Thanks!