947918 - Support seeking to end of BlobView

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Currently it's not possible to seek to the end of a BlobView buffer, because seek doesn't accept the length value. This was discovered while working on bug 916850.

If you have a buffer of n bytes length and you're at offset 0, reading n bytes will increment the offset to be equal to the buffer length. Seeking n bytes should give the same result. BlobView already contains the function 'advance', which is just a seek that works relative to the current position, and it supports the described behavior.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

Hi Paul,

Here is a patch for this minor problem that I discovered while working on the OGG meta-data parser.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Anthony,

Please merge the pull request on github. Thanks!

Comment 3

[Anthony Ricaud (:rik)]

Merged in https://github.com/mozilla-b2g/gaia/commit/ebae4e59d2d5f12a9094f30818a888099c07991f

Thomas: You can set checkin-needed to get a patch landed.