Closed Bug 94794 Opened 23 years ago Closed 23 years ago

sidebar grippy is at the top (left in mail), should be in middle

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: sujay, Assigned: andreww)

References

Details

(Keywords: regression, Whiteboard: [polish], PDT+)

Attachments

(2 files)

diffs for fixing splitters in mac classic.
2.26 KB, patch
andreww
: superreview+
Details | Diff | Splinter Review
updated diff for classicBindings.xml
1.54 KB, patch
andreww
: superreview+
Details | Diff | Splinter Review
using 8/10 trunk build on Mac 1) launch netscape in classic skin 2) look at sidebar grippy, its all the way at the top. it should be in the middle. Modern is fine. Its in the middle on Modern skin
It is on modern. Go to mail. the grippy is aligned left on the mail pane seperator
*** Bug 94792 has been marked as a duplicate of this bug. ***
This was not resolved with the fix for bug 93317. -The grippies (horizontal and vertical) are not centered in classic skin -Horizontal grippie( Mail panes)is not centered in modern skin. this has been present since build 2001-08-02-04-trunk
this is now affecting windows and it is present in classic and modern skin. to see this: open mail to see a horizontal pane divider. The grippy is aligned to the left.
OS: Mac System 9.x → All
Hardware: Macintosh → All
Summary: classic skin only: sidebar grippy is at the top, should be in middle → sidebar grippy is at the top, should be in middle
mac classic -> andreww
Assignee: hewitt → andreww
As said before, this is not limited to Mac Classic. This should be re-assigned, probably to Hyatt.
Added regression and nsbranch keywords
Keywords: nsbranch, regression
this has recently begun appearing in linux also
Summary: sidebar grippy is at the top, should be in middle → sidebar grippy is at the top (left in mail), should be in middle
Yep. This is due to the alignment changes from hyatt. Looks like mac classic was overlooked.
Status: NEW → ASSIGNED
this seems like a dup (or related bug) of bug 94180. Apparently they are both, "Grippies aren't where they are supposed to be."
If this is not a dupe, please have your Manager nsbranch+. This looks like one we'd like to fix.
Ok I found out what is wrong and what to fix about mac classic skin. it will behave identical to modern after this patch. This is NOT a dupe of Hyatt's bug though because even after I fixed this on my tree I still get the H-bar left aligned till I clicked on it. Just like modern (Also Just like Toy Factory too)
marking + and 0.9.5
Keywords: nsbranch → nsbranch+
Target Milestone: --- → mozilla0.9.5
sr=hewitt
Attachment #49270 - Flags: superreview+
Attachment #49393 - Flags: superreview+
Who else can review this, so we can get moving on it?
seeking review now
sure, r=hwaara.
dOES THE LAST PATCH HAVE BOTH An r= and sr=?
Jaimejr: Yes, sr=hewitt, r=hwaara.
PDT - please consider letting this in. It's a very easy patch and fixes a most egregious error in mac classic skin.
Whiteboard: [polish]
Whiteboard: [polish] → [polish], PDT+
check it in - PDT+
ok checked into branch. Will check into trunk asap.
verified in 9/26 branch. will verify on trunk after it is fixed there or when this bug is marked RESOLVED-FIXED.
checked into trunk. marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified fixed on mac commercial builds: mac 2001-09-27-03-0.9.4 mac 2001-09-27-04-trunk
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: