947941 - SQLiteDatabaseLockedException from GlobalHistory.add and GlobalHistory.update

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

GlobalHistory.add
https://crash-stats.mozilla.com/report/index/e7d11fcf-e006-448e-9bd0-8f8662131204

GlobalHistory.update
https://crash-stats.mozilla.com/report/index/8f121681-0faf-4624-a296-750702131130

Something is locking the DB and causing crashes. These two paths seem to appear quite a bit in the crash logs. We could just add some code to retry the operation once or twice.

This crash type is currently #3 on Fx26 (beta) and #4 on GA (Fx25).

Comment 1

[Richard Newman [:rnewman]]

There's very little doubt in my mind that this is identical to Bug 947939.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Richard Newman [:rnewman] from comment #1)
> There's very little doubt in my mind that this is identical to Bug 947939.

Agreed, but finding the root cause could be an epic adventure. Should we consider this bug and bug 947939 as ways to retry, and keep Fennec running, rather than crashing?

Comment 3

[Richard Newman [:rnewman]]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> (In reply to Richard Newman [:rnewman] from comment #1)
> > There's very little doubt in my mind that this is identical to Bug 947939.
> 
> Agreed, but finding the root cause could be an epic adventure. Should we
> consider this bug and bug 947939 as ways to retry, and keep Fennec running,
> rather than crashing?

I would be open to attempting a retry, so long as we had some kind of mechanism for finding out whether retrying (or muffling) left the browser in any better state. No point in retrying if we're never going to be able to write to the DB ever again.

How many of these crashes are on builds that are submitting telemetry?

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.