The default bug view has changed. See this FAQ.

Handle OOM without MOZ_CRASH in CodeGeneratorShared::jumpToBlock

RESOLVED FIXED in mozilla29

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: decoder, Assigned: decoder)

Tracking

(Blocks: 2 bugs, {crash, sec-want})

Trunk
mozilla29
x86_64
Linux
crash, sec-want
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8344673 [details] [diff] [review]
js-jumpToBlock-oom.patch

Right now, CodeGeneratorShared::jumpToBlock calls MOZ_CRASH on OOM. I talked to Brian and instead he says, we should use masm.propagateOOM. The attached patch does that and I confirmed it fixes the problem.
Attachment #8344673 - Flags: review?(bhackett1024)
Attachment #8344673 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 1

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f4087c5cfc5
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/0f4087c5cfc5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.