As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact bugzilla-admin@mozilla.org
Last Comment Bug 947958 - Handle OOM without MOZ_CRASH in CodeGeneratorShared::jumpToBlock
: Handle OOM without MOZ_CRASH in CodeGeneratorShared::jumpToBlock
Status: RESOLVED FIXED
: crash, sec-want
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Linux
: -- critical (vote)
: mozilla29
Assigned To: Christian Holler (:decoder)
: general
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: langfuzz 912928
  Show dependency treegraph
 
Reported: 2013-12-09 08:22 PST by Christian Holler (:decoder)
Modified: 2013-12-09 20:42 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
js-jumpToBlock-oom.patch (1.81 KB, patch)
2013-12-09 08:22 PST, Christian Holler (:decoder)
bhackett1024: review+
Details | Diff | Splinter Review

Description User image Christian Holler (:decoder) 2013-12-09 08:22:27 PST
Created attachment 8344673 [details] [diff] [review]
js-jumpToBlock-oom.patch

Right now, CodeGeneratorShared::jumpToBlock calls MOZ_CRASH on OOM. I talked to Brian and instead he says, we should use masm.propagateOOM. The attached patch does that and I confirmed it fixes the problem.
Comment 1 User image Christian Holler (:decoder) 2013-12-09 14:13:14 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f4087c5cfc5
Comment 2 User image Wes Kocher (:KWierso) 2013-12-09 20:42:56 PST
https://hg.mozilla.org/mozilla-central/rev/0f4087c5cfc5

Note You need to log in before you can comment on or make changes to this bug.