Closed
Bug 947986
Opened 11 years ago
Closed 11 years ago
Use more jshint options to maintain style
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
Details
Attachments
(1 file)
When switching over support to using grunt for our linting I went a little easy on the options to try and reduce the changeset as much as possible.
Let's get a little more strict.
Assignee | ||
Comment 1•11 years ago
|
||
Turns out the only real option we could of added was specifying expected indentation but that broke a sort of "just known" rule of how we indent in certain situations. Decided against putting that in.
Attachment #8344803 -
Flags: review?(scott)
Updated•11 years ago
|
Attachment #8344803 -
Flags: review?(scott) → review+
Comment 2•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/791c8e677b4d1bd58cd73369ea4c638096fdd5cc
Fix Bug 947986 - Store JSHINT options in our .jshintrc file instead
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•