948003 - crash in _JNIEnv::CallStaticObjectMethod(_jclass*, _jmethodID*, ...) | anp_system_loadJavaClass(_NPP*, char const*)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

This bug was filed from the Socorro interface and is 
report bp-ac3f0152-5a3d-4bdf-887c-76c242131208.
=============================================================

Seems to be Flash related. Will investigate URLs later.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

I can reproduce this easily just by going to http://people.mozilla.org/~jwillcox/flash/flash_test.html

Comment 2

[Aaron Train [:aaronmt]]

https://crash-stats.mozilla.com/report/index/dfc696a3-8528-48b2-bc9d-0bead2131205 if needed too has a comment/email

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

STR:
* Go to YouTube
* Request desktop site
* Click on a video
* Activate Flash
* Press the full screen button
+ Crash

* Does not affect HTML <video>

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Mark GeckoAppShell.loadPluginClass() as used from JNI

Looks like this got broken when ProGuard was enabled.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8345970 [details] [diff] [review]
Mark GeckoAppShell.loadPluginClass() as used from JNI

Review of attachment 8345970 [details] [diff] [review]:
-----------------------------------------------------------------

r=blassey if you didn't intend to remove jSetSelectedLocale and drop that part of the patch

::: widget/android/GeneratedJNIWrappers.h
@@ -162,5 @@
>      static jmethodID jScheduleRestart;
>      static jmethodID jSendMessageWrapper;
>      static jmethodID jSetFullScreen;
>      static jmethodID jSetKeepScreenOn;
> -    static jmethodID jSetSelectedLocale;

why?

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #5)
> Comment on attachment 8345970 [details] [diff] [review]
> Mark GeckoAppShell.loadPluginClass() as used from JNI
> 
> Review of attachment 8345970 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=blassey if you didn't intend to remove jSetSelectedLocale and drop that
> part of the patch
> 
> ::: widget/android/GeneratedJNIWrappers.h
> @@ -162,5 @@
> >      static jmethodID jScheduleRestart;
> >      static jmethodID jSendMessageWrapper;
> >      static jmethodID jSetFullScreen;
> >      static jmethodID jSetKeepScreenOn;
> > -    static jmethodID jSetSelectedLocale;
> 
> why?

*shrug*

That file is automatically generated. I didn't change that line. I'd say someone modified it by hand and forgot to remove that?

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

The jSetSelectedLocale stuff was removed in https://hg.mozilla.org/mozilla-central/rev/cd918aef9e64 but the part in the header remained.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e6bdc10cf33

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8345970 [details] [diff] [review]
Mark GeckoAppShell.loadPluginClass() as used from JNI

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 709230 
User impact if declined: Flash goes boom
Testing completed (on m-c, etc.): None yet
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e6bdc10cf33

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3ec4c87136ca