Closed Bug 948040 Opened 6 years ago Closed 6 years ago

Back out the download manager from 1.3

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3+, firefox28 fixed, b2g-v1.3 fixed)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)
blocking-b2g 1.3+
Tracking Status
firefox28 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: jsmith, Assigned: arcturus)

References

Details

(Keywords: late-l10n, Whiteboard: [systemsfe])

Attachments

(2 files)

Per today's go/no go discussion, we've decided to pref off the download manager on 1.3. When 1.3 branches, we should prep & land a patch to pref off the download manager on 1.3.
blocking-b2g: --- → 1.3?
If I understood well what we agreed yesterday was to back out everything from 1.3 branch instead of pref off
(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #1)
> If I understood well what we agreed yesterday was to back out everything
> from 1.3 branch instead of pref off

Yeah, back out is right if it can be done cleanly. Let me fix the bug title to reflect that.
Summary: Pref off the download manager on 1.3 → Back out the download manager from 1.3
blocking-b2g: 1.3? → 1.3+
Just one more thing, back out of API implementation is the most important thing, because it will start downloads even if no UI is present
There's no need to backout everything. But we know what to do...
Whiteboard: [systemsfe]
Really? We can simply turn off the API with a pref. Aren't the hooks in Gaia something we can key off of the same pref?
(In reply to Ghislain 'Aus' Lacroix from comment #5)
> Really? We can simply turn off the API with a pref. Aren't the hooks in Gaia
> something we can key off of the same pref?

That would need a pref <-> setting bridge. I'm not a fan of doing that here, but I'll defer to Gregor.
True, that's not ideal. Maybe we pref-off the API itself which is clean and easy to do and back-out the Gaia bits only?
(In reply to Ghislain 'Aus' Lacroix from comment #7)
> True, that's not ideal. Maybe we pref-off the API itself which is clean and
> easy to do and back-out the Gaia bits only?

I would prefer that, yes.
Assignee: nobody → arcturus
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Assignee: arcturus → francisco.jordano
This backout has been done reverting 23 commits in order related to DM.

No conflicts during the reverts. Please verify the content.
Attachment #8348649 - Flags: review?(felash)
Attachment #8348649 - Flags: review?(ehung)
Attachment #8348649 - Flags: review?(crdlc)
Attachment #8348649 - Flags: review?(borja.bugzilla)
Attachment #8348649 - Flags: review?(anygregor)
Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

It looks good. I've checked all changes in shared and system what I did and all of them were reverted successfully. Bye download manager
Attachment #8348649 - Flags: review?(crdlc) → review+
Guys previously you can find the backout from gaia. Finally was pretty straight forward. What will be the final solution for the API side?

Cheers,
F.
Sorry forgot to add a needinfo for my previous comment.
Flags: needinfo?(anygregor)
Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

Thanks!
Attachment #8348649 - Flags: review?(anygregor) → review+
Flags: needinfo?(anygregor)
Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

Tried it on the phone, the notification part still works, so I'm happy ;)
Attachment #8348649 - Flags: review?(felash) → review+
Attachment #8348649 - Flags: review?(borja.bugzilla) → review+
Assignee: francisco.jordano → nobody
Comment on attachment 8348649 [details] [review]
Backout from 1.3 branch

thanks!
Attachment #8348649 - Flags: review?(ehung) → review+
Quick question John, should I merge, this against 1.3 or you will do it?
Flags: needinfo?(jhford)
Just do it Francisco :)
(don't know why you're not assignee)
@Julien, cause we still need the gecko backout/setting solution in gecko ;)
Landed in v1.3:

https://github.com/mozilla-b2g/gaia/commit/1594923a1f1eb6f86da7fa8087532f58479773a5

Now waiting for the api solution to close this bug.
Flags: needinfo?(jhford)
This shouldn't be marked fixed yet - we need to land a fix on the gecko side to back out/pref off the download API.
Well, Gaia part is fixed, remaining part not yet landed is Gecko part, and as far as I know it requires a different status flag.
(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #21)
> Well, Gaia part is fixed, remaining part not yet landed is Gecko part, and
> as far as I know it requires a different status flag.

Ah right. status-firefox28 would track that.
Attached patch gecko patchSplinter Review
Attachment #8350221 - Flags: review?(aus)
Comment on attachment 8350221 [details] [diff] [review]
gecko patch

Review of attachment 8350221 [details] [diff] [review]:
-----------------------------------------------------------------

See you in 1.4 Downloads API!
Attachment #8350221 - Flags: review?(aus) → review+
Comment on attachment 8350221 [details] [diff] [review]
gecko patch

Review of attachment 8350221 [details] [diff] [review]:
-----------------------------------------------------------------

I want to do it a bit differently.
Attachment #8350221 - Flags: review+
Keywords: late-l10n
Closing this out as we've now backed this out in gecko & gaia.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → francisco.jordano
You need to log in before you can comment on or make changes to this bug.