948091 - Change pagination serializer settings

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Code Quality, defect, P3)

Description

[Mathieu Pillard [:mat]]

When we switched to DRF, we kept compatibility with how tastypie does pagination by setting the default pagination serialization class to one built for this purpose. However, it needs something in the view to properly work. So I built the necessary code in MarketplaceView base class.

This cause problems when we forget to inherit from MarketplaceView, so this kinda sucks. This caused bug 948084 and bug 945709. 

We should investigate whether there is an alternative solution, but this seems like the best plan: Let's have 2 pagination serializers:

- A basic one
- Another one with the tastypie compatibility (offset-style pagination)

Instead of defaulting to the second one, we should default to the basic one in the settings and only use the other in MarketplaceView and its children, by setting pagination_serializer_class.

Comment 2

[Mathieu Pillard [:mat]]

Never going to happen.