948099 - Use JS_DEBUG instead of DEBUG

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Sean Stangl [:sstangl]]

Bug 939505 changed exported headers to use JS_DEBUG to mitigate linking issues. This bug changes the rest of the engine to use JS_DEBUG, to avoid mistakes caused by having two systems.

Comment 1

[Sean Stangl [:sstangl]]

Attachment: Convert to JS_DEBUG

This converts the rest of the engine, with the exception of some external libraries that don't include JS headers.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8344976 [details] [diff] [review]
Convert to JS_DEBUG

Review of attachment 8344976 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

In jsgc.cpp:
>-#include <string.h>     /* for memset used when DEBUG */
>+#include <string.h>     /* for memset used when JS_DEBUG */

The comment doesn't seem to be true anymore; remove it if you feel like it.

Comment 3

[Sean Stangl [:sstangl]]

Holding off on this bug temporarily -- Bug 948638 will hopefully let us remove JS_DEBUG even from public headers, at which point we can continue using DEBUG everywhere.

Comment 4

[Sean Stangl [:sstangl]]

There are still some valid uses of JS_DEBUG after Bug 948638 landed, but most are minor. Chipping away at them is probably the right way forward.