Closed
Bug 948099
Opened 12 years ago
Closed 11 years ago
Use JS_DEBUG instead of DEBUG
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: sstangl, Unassigned)
References
Details
Attachments
(1 file)
181.54 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Bug 939505 changed exported headers to use JS_DEBUG to mitigate linking issues. This bug changes the rest of the engine to use JS_DEBUG, to avoid mistakes caused by having two systems.
Reporter | ||
Comment 1•12 years ago
|
||
This converts the rest of the engine, with the exception of some external libraries that don't include JS headers.
Attachment #8344976 -
Flags: review?(jorendorff)
Comment 2•12 years ago
|
||
Comment on attachment 8344976 [details] [diff] [review]
Convert to JS_DEBUG
Review of attachment 8344976 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you!
In jsgc.cpp:
>-#include <string.h> /* for memset used when DEBUG */
>+#include <string.h> /* for memset used when JS_DEBUG */
The comment doesn't seem to be true anymore; remove it if you feel like it.
Attachment #8344976 -
Flags: review?(jorendorff) → review+
Reporter | ||
Comment 3•12 years ago
|
||
Holding off on this bug temporarily -- Bug 948638 will hopefully let us remove JS_DEBUG even from public headers, at which point we can continue using DEBUG everywhere.
Reporter | ||
Comment 4•11 years ago
|
||
There are still some valid uses of JS_DEBUG after Bug 948638 landed, but most are minor. Chipping away at them is probably the right way forward.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•