Bump mozbase dependencies to fix rmtree/remove issues in Mozmill and fixup import lines.

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-2.0.2+])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
In bug 944684 I updated various mozbase packages for a better handling when it comes to removing files and directories. This is done via mozfile now. We have to bump mozrunner to 5.28 and also fix any instances of those shutil and os methods.
(Assignee)

Updated

4 years ago
Blocks: 948121
(Assignee)

Updated

4 years ago
Summary: Bump mozbase dependencies to fix rmtree/remove issues in Mozmill → Bump mozbase dependencies to fix rmtree/remove issues in Mozmill and fixup import lines.
(Assignee)

Comment 1

4 years ago
Created attachment 8345734 [details] [diff] [review]
Patch v1

None of the code in Mozmill itself uses shutil.rmtree() or os.remove() so we are fine. Those are only tests, which I would like to update later if necessary at all.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #8345734 - Flags: review?(dave.hunt)
Attachment #8345734 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 8345822 [details] [diff] [review]
Backport v1

Backport patch for hotfix-2.0, given that some changes of master haven't been alnded on hotfix-2.0
Attachment #8345822 - Flags: review?(dave.hunt)
Attachment #8345822 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 3

4 years ago
Patches landed as:
https://github.com/mozilla/mozmill/commit/e462504b742f2dae8f6f3d6353a1e28e61c40e5e (master)
https://github.com/mozilla/mozmill/commit/aeef90970d82ccfb99f9d773ef8d557c354db04b (hotfix-2.0)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.