Closed
Bug 948201
Opened 11 years ago
Closed 11 years ago
Use a StaticRefPtr for XPTInterfaceInfoManager
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
2.81 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Bug 936964 exposed some weirdness with XPTI refcounting.
|
Assignee | |
Comment 1•11 years ago
|
||
This uses a StaticRefPtr for |gInterfaceInfoManager|. The nulling in ~XPTInterfaceInfoManager() is needed to keep ASan happy. I also removed gCallCount because it's unused.
Attachment #8344994 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•11 years ago
|
Summary: imported patch xpti-StaticPtr → Use a StaticRefPtr for XPTInterfaceInfoManager
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8344994 [details] [diff] [review] imported patch xpti-StaticPtr r=me, but I'd still love to understand why ASAN dislikes that null-set. Maybe you're right and it's an ASAN bug. Ah, well.
Attachment #8344994 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d33302ff2866
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d33302ff2866
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•