Closed Bug 948276 Opened 6 years ago Closed 6 years ago

Lazy load accessibility support

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

(Keywords: perf, Whiteboard: [c=memory p= s=2013.12.20 u=tarako])

Attachments

(1 file)

That helps a bit with memory usage for the majority of users.
Blocks: 128RAM
Assignee: nobody → fabrice
Attachment #8345121 - Flags: review?(eitan)
blocking-b2g: --- → 1.3?
Whiteboard: [tarako]
Comment on attachment 8345121 [details] [diff] [review]
lazy-accessfu.patch

Review of attachment 8345121 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review from Eitan since he's on vacation. I tested this, and it still starts up fine for me if I load my custom build which enables the screen reader straight away on startup and keeps the setting on. Hope it doesn't try to load it again and again if the user toggles the screen reader setting in Developer Options off and back on again. You should test that to make sure it doesn't cause any problems. I cannot test this because once the screen reader is off, I'm stuck. ;-)
Attachment #8345121 - Flags: review?(eitan) → review+
Hi Fabrice, do we know how much saving this will give us? this will help to decide if this is needed for tarako
Flags: needinfo?(fabrice)
(In reply to Joe Cheng [:jcheng] from comment #5)
> Hi Fabrice, do we know how much saving this will give us? this will help to
> decide if this is needed for tarako

It's not a big saving, but it's absolutely not risky so we should take it on tarako (but not necessarily on 1.3)
Flags: needinfo?(fabrice)
Keywords: perf
Whiteboard: [tarako] → [c=memory p= s= u=] [tarako]
triage: leave it on trunk but let partner take this on their branch
blocking-b2g: 1.3? → ---
Whiteboard: [c=memory p= s= u=] [tarako] → [c=memory p= s= u=] [tarako][no_uplift]
james, this could save 1MB storage but won't be in 1.3. do you want to take it?
Flags: needinfo?(james.zhang)
Why not merge the patch into v1.3 branch, is there any side effect?
Flags: needinfo?(james.zhang)
(In reply to James Zhang from comment #9)
> Why not merge the patch into v1.3 branch, is there any side effect?

There's no strong reason to take that on "standard" 1.3. This should be cherry picked for Tarako though once we branch.
triage: 1.3T+ to get it merged to 1.3T branch
blocking-b2g: --- → 1.3T+
Whiteboard: [c=memory p= s= u=] [tarako][no_uplift] → [c=memory p= s= u=]
Whiteboard: [c=memory p= s= u=] → [c=memory p= s=2013.12.20 u=tarako]
You need to log in before you can comment on or make changes to this bug.