948307 - [DSDS] SIM manager is loaded about half second later than other items in Settings when first launch the list.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Enpei]

Attachment: time stamp: 15:45, 12/10.

When first time launch Settings, it takes about half second to display SIM manager in the list. Hope system can behave consistently for at least items on the page shown right after launching Settings.

* Build Number                
Fugu
Gaia      fbb6ce88ce8b7bd4d2efdb7a4a9f5a3c145f3eab
Gecko     a0bb585098cc89c454fac0297b5ef748d5cab82c
BuildID   20131210063021
Version   28.0a1

* Reproduce Steps
1. Remove Settings from task manager
2. Launch Settings.
3. Check SIM manager after item list is shown.

* Expected Result
SIM manager should be shown with other items at the same time.

* Actual Result
After other items are listed(items on the page without scrolling down the list) for about half second, SIM manager will be seen.

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: VID_0001.3gp

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Displaying SIM manager in the first place regresses the settings app launch time. (https://bugzilla.mozilla.org/show_bug.cgi?id=932731#c32) There is a trade off here. Neo, could you provide some inputs about the issue? We would like to determine if this impacts the UX.

Comment 3

[Enpei]

loop in DSDS UX owner Carrie.

Comment 4

[Enpei]

(In reply to Arthur Chen [:arthurcc] from comment #2)
> Displaying SIM manager in the first place regresses the settings app launch
> time. (https://bugzilla.mozilla.org/show_bug.cgi?id=932731#c32) There is a
> trade off here. Neo, could you provide some inputs about the issue? We would
> like to determine if this impacts the UX.

Hi Carrie, could you help to comment on Arthur's question?

Comment 5

[Carrie Wang [New account: [e-mail]]]

Hi both, 

I've checked the interaction on devices with Enpei and I really expect that SIM manager should be shown with other items at the same time, otherwise, it will be really weird. :(
Thanks!

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Neo proposed an idea of moving the SIM manager item to the after so it won't be displayed when launching settings app. Not sure if it feasible?

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi all,

Just discussed with Vicamo, the thing gecko could do is delaying the init to MobileConnectionArray::IndexedGetter.
So in MobileConnectionArray constructor we only set the array length but don't init the element. This could help but need to have WIP first to know how much it actually improves.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #7)
> Hi all,
> 
> Just discussed with Vicamo, the thing gecko could do is delaying the init to
> MobileConnectionArray::IndexedGetter.
> So in MobileConnectionArray constructor we only set the array length but
> don't init the element. This could help but need to have WIP first to know
> how much it actually improves.

Thanks Hsin-Yi,

we can make a test to see whether that WIP works well with Gaia as what we thought. 

Thanks :P

Comment 9

[Jessica Jong [:jessica] (inactive)]

Attachment: [WIP] delay mobileconnections initialization (git format)

EJ, 

Could you try the attached WIP patch? It's a quick patch, not sure if everything works as expected.

Thanks.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #9)
> Created attachment 8346515 [details] [diff] [review]
> [WIP] delay mobileconnections initialization (git format)
> 
> EJ, 
> 
> Could you try the attached WIP patch? It's a quick patch, not sure if
> everything works as expected.
> 
> Thanks.

okkk ! I'll give a try and reply back soon. 

Thanks Jessica.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: temp patch on gaia

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #9)
> Created attachment 8346515 [details] [diff] [review]
> [WIP] delay mobileconnections initialization (git format)
> 
> EJ, 
> 
> Could you try the attached WIP patch? It's a quick patch, not sure if
> everything works as expected.
> 
> Thanks.

Hi Jessica, I just updated the gaia part and tested on Fugu. 

They all work as what I expect and I think you can apply my patch on Gaia and give it a try on your device.

I will try to run b2gperf tool later because my build environment is broken due to some unknown error and I am still fixing it.

Comment 13

[Carrie Wang [New account: [e-mail]]]

(In reply to Arthur Chen [:arthurcc] (PTO 12/25 ~ 1/5) from comment #6)
> Neo proposed an idea of moving the SIM manager item to the after so it won't
> be displayed when launching settings app. Not sure if it feasible?

Since this is for dual SIM devices, SIM manager should be promoted as high priority. Hence, I don't suggest to move the item in this case. Thanks!

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi all, I tested on Fugu with two different situations below :

1. With new Gecko & Gaia patch : 

2013-12-23 18:37:46,413 B2GPerfRunner INFO    | Results for Settings, cold_load_time: median:881, mean:1174, std: 508, max:2215, min:813, all:1964,881,1016,2062,1988,1966,885,1944,862,907,2021,860,830,881,1943,2215,821,888,873,840,859,854,863,867,813,902,882,860,841,851

2. Without Gecko & Gaia patch (master) :

2013-12-23 18:51:59,518 B2GPerfRunner INFO    | Results for Settings, cold_load_time: median:1572, mean:1401, std: 234, max:1648, min:1061, all:1376,1587,1594,1587,1088,1091,1607,1071,1610,1108,1579,1645,1575,1591,1648,1561,1110,1594,1591,1637,1570,1624,1609,1061,1143,1133,1141,1163,1177,1163

Based on the median value we got from b2gperf (b2gperf --delay=10 Settings), it seems that if we have these two patches on Gaia and Gecko will make simcard manager show up quickly and users will not recognize the latency time. 

If there are no side effects on Gecko and Gaia, I think this approach is good to go. 

Thanks all :)

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

ni? Carrie, Arthur and Hsin-Yi for more discussion based on the experiment I tried above.

Comment 16

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thanks Jessica's WIP. I think the idea is fine to go. A separate bug 953005 has been filed for the gecko enhancement.

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

EJ, did you test the patches with unagi? I was wondering do users notice the disappearing of the menu item with single sim devices as we show the menu item by default.

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

My Inari works well without the patch !

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to EJ Chen [:eragonj](PTO: 12/25 ~ 1/5) from comment #18)
> My Inari works well without the patch !

I mean Gecko patch :P

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

I thought we are going to land both the gaia and gecko patches? If so we need to test the patches with a single sim device.

Comment 21

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] (PTO 12/25 ~ 1/5) from comment #20)
> I thought we are going to land both the gaia and gecko patches? If so we
> need to test the patches with a single sim device.

Yeah I know, Arthur. 

I am trying to build a new gecko on my desktop now. Thanks :)

Comment 22

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

After testing on Inari, it works well and there is no blinking problem when Gecko & Gaia patches got applied. 

Here comes the performance test : 

1. With Gecko & Gaia patch : 

2013-12-24 16:45:46,347 B2GPerfRunner INFO    | Results for Settings, cold_load_time: median:747, mean:760, std: 46, max:947, min:721, all:947,738,740,753,764,730,744,737,892,747,743,747,739,750,721,786,802,738,763,741,732,755,736,747,749,746,799,748,740,750

2. Compared with the data from datazilla (http://goo.gl/s1ECiB) :  

Application: settings 
Gaia Revision: 9ed515d0ede35198
Date:2013-12-24 14:08:52
Avg:1209.23 Min:1159 Max:1321 Std:53.48

I think this approach works well as what we have expected no matter on single sim device or dual sim. Hope this information helps :)

Comment 23

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

By the way, on engineering side, I think Gecko needs to apply its patch first so that we can make sure Gaia change will not influence user experiences (blinking panel).

Comment 24

[Carrie Wang [New account: [e-mail]]]

Hi, I've checked the new patch with EJ. I think it looks fine now, although the latency of getting into Settings APP is quite obvious, but at least SIM manager shows up at the same time with other items.
Thanks!

Comment 25

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to EJ Chen [:eragonj](PTO: 12/25 ~ 1/5) from comment #23)
> By the way, on engineering side, I think Gecko needs to apply its patch
> first so that we can make sure Gaia change will not influence user
> experiences (blinking panel).

Agree. Bug dependency has been set.

Comment 26

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch

Comment 27

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch

Comment 28

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Added a new patch based on master code (original patch is outdated.) and will ask for review after using new Gecko build.

Comment 29

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8361453 [details] [review]
patch on master

Hi Arthur, when you got the newest build with Gecko patch, please help me review this small patch. Thanks ! :)

Comment 30

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8361453 [details] [review]
patch on master

r=me. Please merge with travis green, thanks!

Comment 31

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I am nominating this as 1.3+ because this issue directly affects user experience.

Comment 32

[Preeti Raghunath(:Preeti)]

Beatriz,

Can you please comment if this would block IOT. The flash seen lasts for 1/2 a second and wondering if we can live with it.

Comment 33

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, just merged this change on gaia/master : dd16763b6301f5df0e3531e3f17aad8f46ff10ad

:)

Comment 34

[Beatriz Rodríguez [:brg]]

(In reply to Preeti Raghunath(:Preeti) from comment #32)
> Beatriz,
> 
> Can you please comment if this would block IOT. The flash seen lasts for 1/2
> a second and wondering if we can live with it.
We will manage it. Thanks for asking.

Comment 35

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted dd16763b6301f5df0e3531e3f17aad8f46ff10ad to:
v1.3: 8493b838144ae9ff7bef9cac1f678aa1e5ace0ff

Comment 36

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #35)
> Uplifted dd16763b6301f5df0e3531e3f17aad8f46ff10ad to:
> v1.3: 8493b838144ae9ff7bef9cac1f678aa1e5ace0ff

Thanks John !

Comment 37

[Enpei]

Verified on 
Fugu
Gaia      6fbeac2415f07f10de181f0877ddf67ee299b885
Gecko     086e69971516130ad297c7f950dfb42a995217e9
BuildID   20140123115514
Version   28.0a2

Now SIM Manager will show along with Call/Messaging/Cellular & Data.