948341 - Convert Dialer to new Notification API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[:gerard-majax]

apps/communications/dialer/js/dialer.js:
  - sending notification for missed calls
  - no payload, opens call log

Comment 1

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/14801

Please find attached a first version of the modification. This depends on the NotificationHelper._checkPermissions() code that is not yet available. Whether or not we use it is open to debate.

This version of the PR does not yet have any tests, it's just for reference. It has however been tested on device (Inari) and works well.

Comment 2

[:gerard-majax]

I'm able to make use of the notification without requiring _checkPermissions(). Pull request is updated, and notification are now removed only when we get to the call log, which should fix bug 926318.

Comment 3

[:gerard-majax]

I've updated the PR adding unit tests that checks for mocked notification object .close() call.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8349317 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/14801

Still some work (comments on github) but I'm really glad we're switching to the new API, lovely.

Comment 5

[:gerard-majax]

Comment on attachment 8349317 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/14801

Thanks for the fast review, I've updated the PR :)

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8349317 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/14801

All good, thanks!

Comment 7

[:gerard-majax]

Green travis at https://travis-ci.org/mozilla-b2g/gaia/builds/15712905, I'll merge tomorrow.

Comment 8

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/89f0a85f8d7d11da9b9b02f855a722ef501d8ba9