Closed
Bug 948341
Opened 11 years ago
Closed 11 years ago
Convert Dialer to new Notification API
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file)
apps/communications/dialer/js/dialer.js: - sending notification for missed calls - no payload, opens call log
Assignee | ||
Comment 1•11 years ago
|
||
Please find attached a first version of the modification. This depends on the NotificationHelper._checkPermissions() code that is not yet available. Whether or not we use it is open to debate. This version of the PR does not yet have any tests, it's just for reference. It has however been tested on device (Inari) and works well.
Attachment #8349317 -
Flags: feedback?(etienne)
Assignee | ||
Comment 2•11 years ago
|
||
I'm able to make use of the notification without requiring _checkPermissions(). Pull request is updated, and notification are now removed only when we get to the call log, which should fix bug 926318.
Assignee | ||
Comment 3•11 years ago
|
||
I've updated the PR adding unit tests that checks for mocked notification object .close() call.
Assignee | ||
Updated•11 years ago
|
Attachment #8349317 -
Flags: feedback?(etienne) → review?(etienne)
Comment 4•11 years ago
|
||
Comment on attachment 8349317 [details] [review] Link to Github https://github.com/mozilla-b2g/gaia/pull/14801 Still some work (comments on github) but I'm really glad we're switching to the new API, lovely.
Attachment #8349317 -
Flags: review?(etienne)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8349317 [details] [review] Link to Github https://github.com/mozilla-b2g/gaia/pull/14801 Thanks for the fast review, I've updated the PR :)
Attachment #8349317 -
Flags: review?(etienne)
Comment 6•11 years ago
|
||
Comment on attachment 8349317 [details] [review] Link to Github https://github.com/mozilla-b2g/gaia/pull/14801 All good, thanks!
Attachment #8349317 -
Flags: review?(etienne) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Green travis at https://travis-ci.org/mozilla-b2g/gaia/builds/15712905, I'll merge tomorrow.
Assignee | ||
Comment 8•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/89f0a85f8d7d11da9b9b02f855a722ef501d8ba9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•