948383 - Move all `home button event` into GaiaDevice class

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Zac C (:zac)]

In line with our plan to use GaiaDevice as a representation of all non-UI interactions with the device, move anywhere we have:
self.marionette.execute_script("window.wrappedJSObject.dispatchEvent(new Event('home'));")

into a method in GaiaDevice, named appropriately.

Migrate all tests to use this method.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Bonus points for updating gcli to use this new method. See https://github.com/mozilla-b2g/gaia/blob/6d8df043e1eafa576c16f22bcd2579012b959fd6/tests/python/gaia-ui-tests/gaiatest/gcli.py#L165

Comment 2

[akruglov]

I'd like to work on this issue.

Comment 3

[akruglov]

Attachment: https://github.com/mozilla-b2g/gaia/pull/14587

Please, review. Who else can I ask for review?

Comment 4

[Zac C (:zac)]

Comment on attachment 8346102 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14587

I will r? properly tomorrow but in the meantime we need to get rwood's r? on this too as it affects some of his tests.

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8346102 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14587

Looks good and both of the updated endurance tests work fine. Thank you!

Comment 6

[Zac C (:zac)]

Comment on attachment 8346102 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14587

r+ too!

Comment 7

[Florin Strugariu [:Bebe]]

Let's merge this when the tree is reopen

Comment 8

[Florin Strugariu [:Bebe]]

Merged in https://github.com/mozilla-b2g/gaia/commit/e1d81dbebb8abdfbc5f222ac1a2ae1055017a8f2

Comment 9

[Kevin Grandon :kgrandon]

Please ensure to squash merges before landing. Each commit should link to a bug number for easier tracking and cleaner commit history.

Comment 10

[Kevin Grandon :kgrandon]

Hi, we backed out the fix due to not being squashed. I also had time to re-apply and squash the commits. The new commit has landed here (with proper author credit): https://github.com/mozilla-b2g/gaia/commit/62d2e42a1499c547e46d9c21b17bdebce9f04e12

Adding needsinfo? for Florian to see why we merged this pull request, and to make sure we don't do so again in the future.

Comment 11

[Zac C (:zac)]

Thanks for fixing this up for us Kevin, it definitely shouldn't have been merged without the squash beforehand.

Comment 12

[Florin Strugariu [:Bebe]]

My mistake Kevin.  
I did not notice there where multiple commits in that pull.
Promise it will never happen again