In line with our plan to use GaiaDevice as a representation of all non-UI interactions with the device, move anywhere we have: self.marionette.execute_script("window.wrappedJSObject.dispatchEvent(new Event('home'));") into a method in GaiaDevice, named appropriately. Migrate all tests to use this method.
Bonus points for updating gcli to use this new method. See https://github.com/mozilla-b2g/gaia/blob/6d8df043e1eafa576c16f22bcd2579012b959fd6/tests/python/gaia-ui-tests/gaiatest/gcli.py#L165
I'd like to work on this issue.
Created attachment 8346102 [details] [review] https://github.com/mozilla-b2g/gaia/pull/14587 Please, review. Who else can I ask for review?
Attachment #8346102 - Flags: review?(zcampbell)
Comment on attachment 8346102 [details] [review] https://github.com/mozilla-b2g/gaia/pull/14587 I will r? properly tomorrow but in the meantime we need to get rwood's r? on this too as it affects some of his tests.
Attachment #8346102 - Flags: review?(rwood)
Comment on attachment 8346102 [details] [review] https://github.com/mozilla-b2g/gaia/pull/14587 Looks good and both of the updated endurance tests work fine. Thank you!
Attachment #8346102 - Flags: review?(rwood) → review+
Comment on attachment 8346102 [details] [review] https://github.com/mozilla-b2g/gaia/pull/14587 r+ too!
Attachment #8346102 - Flags: review?(zcampbell) → review+
Let's merge this when the tree is reopen
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Please ensure to squash merges before landing. Each commit should link to a bug number for easier tracking and cleaner commit history.
Hi, we backed out the fix due to not being squashed. I also had time to re-apply and squash the commits. The new commit has landed here (with proper author credit): https://github.com/mozilla-b2g/gaia/commit/62d2e42a1499c547e46d9c21b17bdebce9f04e12 Adding needsinfo? for Florian to see why we merged this pull request, and to make sure we don't do so again in the future.
Thanks for fixing this up for us Kevin, it definitely shouldn't have been merged without the squash beforehand.
My mistake Kevin. I did not notice there where multiple commits in that pull. Promise it will never happen again
You need to log in before you can comment on or make changes to this bug.