Closed Bug 948440 Opened 6 years ago Closed 6 years ago

is_gps_enabled checkbox logic is outdated

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Other
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: viorela)

Details

Attachments

(1 file)

Please update the is_gps_enabled property in the Settings app to properly check the state of the checkbox.

Look at the airplane mode checkbox for an example of how to do it properly.

This is a P1 due to intermittent on Travis.
Attachment #8345347 - Flags: review?(zcampbell)
Attachment #8345347 - Flags: review?(trifandreialin)
Attachment #8345347 - Flags: review?(florin.strugariu)
Comment on attachment 8345347 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14541

r+
Attachment #8345347 - Flags: review?(zcampbell)
Attachment #8345347 - Flags: review?(trifandreialin)
Attachment #8345347 - Flags: review?(florin.strugariu)
Attachment #8345347 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/412746a57d09496e989da6b335e438eeef22be78
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → viorela.ioia
You need to log in before you can comment on or make changes to this bug.