is_gps_enabled checkbox logic is outdated

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zcampbell, Assigned: viorela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Please update the is_gps_enabled property in the Settings app to properly check the state of the checkbox.

Look at the airplane mode checkbox for an example of how to do it properly.

This is a P1 due to intermittent on Travis.
(Assignee)

Comment 1

5 years ago
Created attachment 8345347 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14541
Attachment #8345347 - Flags: review?(zcampbell)
Attachment #8345347 - Flags: review?(trifandreialin)
Attachment #8345347 - Flags: review?(florin.strugariu)
(Reporter)

Comment 2

5 years ago
Comment on attachment 8345347 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14541

r+
Attachment #8345347 - Flags: review?(zcampbell)
Attachment #8345347 - Flags: review?(trifandreialin)
Attachment #8345347 - Flags: review?(florin.strugariu)
Attachment #8345347 - Flags: review+
(Reporter)

Comment 3

5 years ago
https://github.com/mozilla-b2g/gaia/commit/412746a57d09496e989da6b335e438eeef22be78
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Assignee: nobody → viorela.ioia
You need to log in before you can comment on or make changes to this bug.