948448 - Clear Private Data doesn't delete seer.sqlite

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[merfius]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131210040201

Steps to reproduce:

Ctrl+Shift+Del, check everything and select Everything time range.


Actual results:

seer.sqlite persists in the user profile.


Expected results:

should be deleted.

Comment 1

[Dave Garrett]

This looks to be not cleared, however I think seer.sqlite might be cleared but just not deleted or even vacuumed. I've got a 28MB one in my primary profile that is mostly empty space.

Comment 2

[u408661]

There are deletes run on all tables when 'clear private data' is selected. I should probably add a vacuum into the clearing to actually free up the disk space.

Comment 3

[u408661]

Attachment: seer_reset_vacuum.patch

This should do it. Builds on top of patches from bug 945779 and bug 947745, so those are prerequisites to this landing.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8346178 [details] [diff] [review]
seer_reset_vacuum.patch

Review of attachment 8346178 [details] [diff] [review]:
-----------------------------------------------------------------

vacuum can be quite expensice, but if you cap the size, then it's probably not going to be that horrible.  let's see how this works.

Comment 5

[Marco Bonardo [:mak]]

Apart the expensiveness issue (that I suppose is happening in background, but may still cap I/O to other consumers), the other drawback is that insertions in freelists are cheaper, so, if you don't vacuum, new insertions will be faster. That said, considered this is only after a clear private data, it may be ignorable.
This falls in the usual size/perf bucket, the answer depends on the scope of the code.
I suppose this db grows so much cause there are many indices on uris, every index duplicates all of the uris, and so there's lots of strings. So maybe another way to look at it could be to reduce the size of the db, by reducing duplication of data caused by indices.

Comment 6

[u408661]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5684d09fa1b

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c5684d09fa1b

Comment 8

[Manuela Muntean [Away]]

Verified as fixed with Firefox 29 beta 3 on Win 7 x64, Ubuntu 13.10 x86 and Mac OS X 10.8.5: seer.sqlite is deleted after clearing the private data.