Test for Bug 938219: "add to an existing contact" activity

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: julienw, Assigned: Bebe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Hey,

having such an integration test could be very useful:

1. User launches the SMS app
2. User taps on a thread for an unmatched contact (I mean: for a plain phone number)
3. User taps on the header
4. User taps on "add to an existing contact"
5. User chooses an existing contact
6. User presses "done"
7. User is moved back to the SMS app

Note that this case is failing until bug 938219 is fixed.
(Reporter)

Updated

4 years ago
See Also: → bug 948473

Updated

4 years ago
Priority: -- → P2
(Assignee)

Comment 1

4 years ago
I will take this
Assignee: nobody → florin.strugariu
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8385415 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835
Attachment #8385415 - Flags: review?(zcampbell)
Attachment #8385415 - Flags: review?(viorela.ioia)
Comment on attachment 8385415 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835

The test runs ok, but there are a few comments you should address.
Attachment #8385415 - Flags: review?(viorela.ioia) → review-
(Assignee)

Updated

4 years ago
Attachment #8385415 - Flags: review- → review?(viorela.ioia)
Attachment #8385415 - Flags: review?(viorela.ioia) → review+

Comment 4

4 years ago
Comment on attachment 8385415 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835

r-
functionally it works very well but for some nits, comments in the pull.

Also this needs to be in the messages folder not contacts, as this flow is owned by the messsage team.
Attachment #8385415 - Flags: review?(zcampbell) → review-
(Assignee)

Updated

4 years ago
Attachment #8385415 - Flags: review- → review?(zcampbell)
(Assignee)

Updated

4 years ago
Attachment #8385415 - Flags: review?(robert.chira)
Attachment #8385415 - Flags: review?(bob.silverberg)
Attachment #8385415 - Flags: review?(robert.chira) → review-
(Assignee)

Updated

4 years ago
Attachment #8385415 - Flags: review- → review?(robert.chira)
Attachment #8385415 - Flags: review?(robert.chira) → review+

Comment 5

4 years ago
Comment on attachment 8385415 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835

super tiny nit, but after that ready to merge.
Attachment #8385415 - Flags: review?(zcampbell) → review-
Comment on attachment 8385415 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835

Comments in the PR.
Attachment #8385415 - Flags: review?(bob.silverberg) → review-
(Assignee)

Comment 7

4 years ago
Comment on attachment 8385415 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835

Updated the pull.


Can you guys/gals review it.


As Zac is in PTO I did not updated his review request but see comment #5
Attachment #8385415 - Flags: review?(viorela.ioia)
Attachment #8385415 - Flags: review?(bob.silverberg)
Attachment #8385415 - Flags: review-
Attachment #8385415 - Flags: review+
Attachment #8385415 - Flags: review?(viorela.ioia) → review+
(Assignee)

Updated

4 years ago
Attachment #8385415 - Flags: review?(andrei.hutusoru)

Comment 8

4 years ago
Merged:

https://github.com/mozilla-b2g/gaia/commit/75bf3cbf589a01d735ebf8653732b721627c8701
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Attachment #8385415 - Flags: review?(bob.silverberg)
Attachment #8385415 - Flags: review?(andrei.hutusoru)
Attachment #8385415 - Flags: review+
You need to log in before you can comment on or make changes to this bug.