948475 - Implement HTMLInputElement.select() for <input type=number>, contrary to the HTML5 spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

I didn't implement HTMLInputElement.select() for <input type=number> because the spec says it doesn't apply:

http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#number-state-%28type=number%29

Turns out that Chrome implements it though, and pdf.js relies on it working:

https://github.com/mozilla/pdf.js/pull/4020#issuecomment-30243390

I think rather than select() just doing nothing, it seems reasonable to forward the call on to its anonymous text control grandchild.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Err, disregard the viewer.css change - I was testing pdf.js locally. Removed from my version of the patch.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 4

[:ehsan akhgari]

Can you please bring this up on the whatwg list so that we can change the spec?  Thanks!

Comment 5

[Jonathan Watt [:jwatt]]

I'm very late starting my PTO. I'll let someone else do that or it can wait until January.

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 8345346 [details] [diff] [review]
patch

Isn't this missing number-selected.html  and number-selected-ref.html

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 8

[Jonathan Watt [:jwatt]]

Oops, sorry. Pushed this by mistake when qfinishing and pushing bug 946184 since this was also applied. I'll leave it in since I'm sure you're fine with this modulo seeing the tests. Let me know if you want any changes.

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa744c4a8948

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fa744c4a8948

Comment 10

[Jonathan Watt [:jwatt]]

Comment on attachment 8345521 [details] [diff] [review]
patch

Bug caused by (feature/regressing bug #): 344616 and its dependencies
User impact if declined: for example, the page number field in pdf.js doesn't select
Testing completed (on m-c, etc.): landed m-i, merged to m-c
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

We're early in the cycle so hopefully this is fine to uplift.

Comment 11

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f66768c50099