948513 - API should have explicit GeoIP header

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: API, defect, P3)

Description

[Matt Basta [:basta]]

Right now we pull the geoip data from `API-Filter`, which isn't ideal because it doesn't give us any data if a region isn't returned.

Instead, there should be some header like `API-Geo` which contains a value like the following:

- error: GeoIP was attempted but the lookup failed.
- worldwide: No region could be detected based on the location.
- us: The user was detected to be in the US

The absence of the API-Geo header should indicate that no GeoIP lookup was performed and the client should take no action.

Comment 1

[Mathieu Pillard [:mat]]

The region middleware also tries to guess the region from the Accept-Language header if geoip lookup returned 'worldwide'. In that case, should we return whatever region we ended up after geoip, or just the 'worldwide' we got from geoip ?

Comment 2

[Matt Basta [:basta]]

Thar be dragons. Either remove that code or make it transparent. I wasn't even aware that we were still doing that in the API.

Comment 3

[Chuck Harmston [:chuck]]

Neither was I. Over the break, can we statsd log the frequency of incidents where we assign a region via SIM, IP, and language? It'd be interesting to see how frequently each of those happen.

Comment 4

[Matt Basta [:basta]]

Over the break? Krupa won't be testing.

Comment 5

[Chuck Harmston [:chuck]]

Commit the logging today, cherry-pick it, investigate results on 1/3.

Comment 6

[Mathieu Pillard [:mat]]

We already log this information, have been for a while.
statsd.incr('z.regions.middleware.source.url')
statsd.incr('z.regions.middleware.source.geoip')
statsd.incr('z.regions.middleware.source.accept-lang')

Comment 7

[Mathieu Pillard [:mat]]

http://graphite.nag.mktmon.services.phx1.mozilla.com/render/?width=1280&height=720&_salt=1387546641.49&from=-7days&minXStep=1&logBase=&minorY=&target=stats.marketplace.z.regions.middleware.source.geoip&target=stats.marketplace.z.regions.middleware.source.accept-lang&target=stats.marketplace.z.regions.middleware.source.url

Not sure what to make of it, because we don't graph the number of times Accept-Language was actually useful (i.e. the number of times it did give us a region)

Comment 8

[Mathieu Pillard [:mat]]

While not strictly a duplicate, bug 964524 (and the consumer pages side bug 966335) make this obsolete.