Closed Bug 948541 Opened 12 years ago Closed 12 years ago

Final pass over the entire UI to get ready for production

Categories

(Webtools Graveyard :: DXR, defect, P1)

Product:
Webtools Graveyard
Component:
DXR
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: espressive, Assigned: espressive)

Details

Some comments from Github to take note of: 1) Love the cosmetics. But clicking the nav elements does nothing because the ilne number anchors still have "l" in front of them: <a id="l51" href="#51"></a>. And remember to rebase it to get #204 out of it. I can help if you like. Essentially, just check this branch out, and git rebase ui. 2) I don't even think this input needs to be here. Do you? ~ i.e. remove type=hidden format field. 3) ajax => plain search: Close but not quite: there's less top margin on the non-AJAX results, and the filenames are a different size and have different left margins. 4) Also, try hitting Return in a blank search field. Weeeeird. There might be additional issues that crept up or was missed. This bug can only be closed once everyone is happy with the look and functionality of the UI.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/3938d94d20d84797306979268124b0ef0a1116e3 Fix Bug 948541, recheck everything regarding the new UI ready for prod https://github.com/mozilla/dxr/commit/c1c2142b947675afee67462b763dca41974d15f6 Merge branch 'bug948541-final-pass-and-tweaks-of-ui' into ui, includes context menu, panel and other tweaks
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.