Use inverted chat toolbar icons with dark Personas

RESOLVED FIXED in Thunderbird 29.0

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 29.0
All
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
The only toolbar not using inverted icons with dark Personas is the chat toolbar. This bug is to fix this.
(Assignee)

Comment 1

5 years ago
Created attachment 8345434 [details] [diff] [review]
chatInverted.patch

The icons aren't new. I took them from addressbook-toolbar-aero-inverted.png. I only resized and doubled the Join Chat icon to have two bubbles like on the normal icon.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8345434 - Flags: ui-review?(josiah)
Attachment #8345434 - Flags: review?(josiah)
(Assignee)

Comment 2

5 years ago
Created attachment 8345435 [details]
chat.png

Screenshot for easier ui-r.
Comment on attachment 8345434 [details] [diff] [review]
chatInverted.patch

Review of attachment 8345434 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks great. Thanks!

::: mail/themes/windows/mail/chat-aero.css
@@ +216,5 @@
> +toolbar:-moz-lwtheme-darktext #button-add-buddy[disabled],
> +toolbar:-moz-lwtheme-darktext #button-join-chat,
> +toolbar:-moz-lwtheme-darktext #button-join-chat[disabled],
> +toolbar:-moz-lwtheme-darktext #button-chat-accounts,
> +toolbar:-moz-lwtheme-darktext #button-chat-accounts[disabled] {

Note to self (or others): I really wish we had a class for all these buttons. Not in the scope of this bug though.
Attachment #8345434 - Flags: ui-review?(josiah)
Attachment #8345434 - Flags: ui-review+
Attachment #8345434 - Flags: review?(josiah)
Attachment #8345434 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8c88c75fb2ff
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in before you can comment on or make changes to this bug.