948575 - [DSDS][System] Enter PIN and PUK for both SIMs

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Wilfred Mathanaraj [:WDM]]

As a user I want to be able to enter SIM PIN and PUK for each SIM

Acceptance Criteria:

AC1: I want to be able to enter SIM PIN1 and PUK1 for each SIM
AC2: I want to be able to enter SIM PIN2 and PUK2 for each SIM
AC3: I must be able to enter it at first startup of device
AC4: I must be able to enter it when the device is reset
AC5: When I skip on FTE I just want to be asked to unlock the current default SIM used for the specific service

Comment 1

[Enpei]

(In reply to Wilfred Mathanaraj [:WDM] from comment #0)
> As a user I want to be able to enter SIM PIN and PUK for each SIM
> 
> Acceptance Criteria:
> 
> AC1: I want to be able to enter SIM PIN1 and PUK1 for each SIM
> AC2: I want to be able to enter SIM PIN2 and PUK2 for each SIM
> AC3: I must be able to enter it at first startup of device
> AC4: I must be able to enter it when the device is reset
> AC5: When I skip on FTE I just want to be asked to unlock the current
> default SIM used for the specific service

Hi Wilfred,

I have some questions.
* AC3 and AC4 are for SIM PIN 1 and PUK 1 only, right? SIM PIN 2 will be seen only when edit FDN.
* AC5 - could you specify more about what those services might be?

Thanks.

Comment 2

[Wilfred Mathanaraj [:WDM]]

AC3 and Ac4 - are for SIM1 PIN1 and SIM2 PIN1. correct that SIM1 PIN2 and SIM2 PIN2 are for when ever they are needed - eg. FDN.

ignore AC5 - its already now covered in AC3 and AC4.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

features should not block release, remove blocking flag

Comment 4

[Fabien Cazenave [:kaze]]

I’m afraid I have to unassign myself for now, as I still don’t have any DSDS device right now.

Feel free to take this bug, I’ll be happy to review patches or do some mentoring.

Comment 5

[Enpei]

Most of acceptance criteria are covered in 1.3 DSDS test cases, add new for PUK 2 which can be found in https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-tag=2565

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I am temporarily blocked due to the lack of having 2 SIMs with PIN2 enabled. Hopefully I will receive them tomorrow.

Comment 7

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This issue is not completely clear to me. As far as I understand there is only one requirement in the end:

-I want to be able to enter SIM PIN1 and PUK1 for each SIM in the FTE

If that is so, Where and how should it work in the FTE? Shouldn't we have some UX involved with this?

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This issue is not completely clear to me. As far as I understand there is only one requirement in the end:

-I want to be able to enter SIM PIN1 and PUK1 for each SIM in the FTE

If that is so, Where and how should it work in the FTE? Shouldn't we have some UX involved with this?

Comment 9

[Enpei]

(In reply to Sergi Mansilla from comment #8)
> This issue is not completely clear to me. As far as I understand there is
> only one requirement in the end:
> 
> -I want to be able to enter SIM PIN1 and PUK1 for each SIM in the FTE
> 
> If that is so, Where and how should it work in the FTE? Shouldn't we have
> some UX involved with this?

Hi Sergi,

I will attach UX guideline and see if page 14 can solve your question or not.

Comment 10

[Enpei]

Don't know why I can't attach it, I've email to you, Sergi.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

AC1: I want to be able to enter SIM PIN1 and PUK1 for each SIM
> This should be supported by the system app in v1.3 already

AC2: I want to be able to enter SIM PIN2 and PUK2 for each SIM
> This should only happen when managing FDN list since PIN2/PUK2 is only used in FDN scenarios (Bug 921971)

AC3: I must be able to enter it at first startup of device
> This should be supported by the system app 

AC4: I must be able to enter it when the device is reset
> this was decided to move to future release 

AC5: When I skip on FTE I just want to be asked to unlock the current default SIM used for the specific service
> i believe we also decided not to do this

so if i am correct, this user story doesn't have anything to be done (except waiting for Bug 921971 to land and verify)

if this is the case, Wilfred, can you update the user stories? thanks

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

I believe AC4 is supported as it is the same as AC3. And we have basic support for AC5. The dialog is prompt when users launch the dialer app or other apps that needs sim cards. The behavior is the same as what we have in single sim devices. The rest of the items are the same as my understanding.

Comment 13

[David Scravaglieri [:scravag]]

What's the status there ? Shall we close this bug ?

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

since all depending bugs are closed, resolved fixed this bug 
and verifyme for QA

Comment 15

[Enpei]

Verified on Fugu
Gaia      b5d0f9b0cd5dce38b79287a9363226b912929270
Gecko     7312341e00e2785419fc4746e291646299ba3018
BuildID   20140313120331
Version   30.0a1

Found other bugs but not directly to block acceptance criteria, so close this bug.
https://bugzilla.mozilla.org/show_bug.cgi?id=983055
https://bugzilla.mozilla.org/show_bug.cgi?id=976470