Closed
Bug 948599
Opened 10 years ago
Closed 10 years ago
Add support for lldb to 'mach debug'
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: snorp, Assigned: snorp)
Details
Attachments
(1 file, 1 obsolete file)
3.87 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Because it's better than gdb maybe?
Attachment #8345465 -
Flags: review?(ehsan)
Comment 1•10 years ago
|
||
Comment on attachment 8345465 [details] [diff] [review] Add lldb support to 'mach debug' Review of attachment 8345465 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/mach_commands.py @@ +773,3 @@ > try: > debugger = which.which('gdb') > except Exception as e: No point in binding this e if you're only going to shadow it
Comment 2•10 years ago
|
||
Comment on attachment 8345465 [details] [diff] [review] Add lldb support to 'mach debug' Review of attachment 8345465 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, over to gps for the sake of following the rules. ;-)
Attachment #8345465 -
Flags: review?(gps)
Attachment #8345465 -
Flags: review?(ehsan)
Attachment #8345465 -
Flags: review+
Updated•10 years ago
|
Component: mach → Build Config
Comment 3•10 years ago
|
||
Comment on attachment 8345465 [details] [diff] [review] Add lldb support to 'mach debug' Review of attachment 8345465 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! ::: python/mozbuild/mozbuild/mach_commands.py @@ +786,2 @@ > import pymake.process > + (argv, badchar) = pymake.process.clinetoargv(debugparams, os.getcwd()) While you're here, please remove the parens around (argv, badchar)
Attachment #8345465 -
Flags: review?(gps) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Address review comments, carry forward r+ from ehsan and gps
Assignee: nobody → snorp
Attachment #8345465 -
Attachment is obsolete: true
Attachment #8345893 -
Flags: review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/26ef39c600b3
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/26ef39c600b3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•