948599 - Add support for lldb to 'mach debug'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add lldb support to 'mach debug'

Because it's better than gdb maybe?

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8345465 [details] [diff] [review]
Add lldb support to 'mach debug'

Review of attachment 8345465 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +773,3 @@
>          try:
>              debugger = which.which('gdb')
>          except Exception as e:

No point in binding this e if you're only going to shadow it

Comment 2

[(no longer active)]

Comment on attachment 8345465 [details] [diff] [review]
Add lldb support to 'mach debug'

Review of attachment 8345465 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, over to gps for the sake of following the rules.  ;-)

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8345465 [details] [diff] [review]
Add lldb support to 'mach debug'

Review of attachment 8345465 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: python/mozbuild/mozbuild/mach_commands.py
@@ +786,2 @@
>              import pymake.process
> +            (argv, badchar) = pymake.process.clinetoargv(debugparams, os.getcwd())

While you're here, please remove the parens around (argv, badchar)

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add lldb support to 'mach debug' r=ehsan,gps

Address review comments, carry forward r+ from ehsan and gps

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26ef39c600b3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26ef39c600b3