Marionette builds should enable NS_WARNING

RESOLVED WONTFIX

Status

Testing
Marionette
RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: bholley, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
If a marionette test fails, its logcat is dumped. But this is a whole lot less useful than it could be, because most of the useful console output is silenced.

Gecko is heavily instrumented with macros (NS_ENSURE_*, NS_WARN_IF, NS_WARNING, etc), all of which boil down to an NS_WARNING call, which does nothing in non-debug builds.

In any b2g builds where we enable the marionette hooks, we should also map NS_WARNING to printf_stderr (which, according to jgriffin, works on b2g where fprintf(stderr, ...) does not).

I would go so far as to hypothesize that this would reduce the amount of time platform devs spend stuck on marionette failures by half. I would write the patch myself, but I don't know what #defines to check.

Do people agree that this would be useful? If so, can we get an owner?
Yes I agree we need better debug output.
Mike or Jed, can you take this?
(Reporter)

Comment 2

4 years ago
For reference, here is the hacky patch that I wrote to turn on NS_WARNING for my try run in bug 944011.

https://hg.mozilla.org/try/rev/52d56f36f9c8
B2G related so closing.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.