Closed Bug 948704 Opened 11 years ago Closed 11 years ago

Changing the date range via the 14 days, 28 days, etc.. ends up emptying the list

Categories

(Socorro :: Webapp, task)

ARM
Gonk (Firefox OS)
task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: nhirata, Assigned: peterbe)

Details

(Whiteboard: [qa+])

Attachments

(1 file, 1 obsolete file)

44 bytes, text/x-github-pull-request
Details | Review
1. go to https://crash-stats.mozilla.com/report/list?signature=__divdi3
2. click on 14 days 
3. click on reports

Expected: reports.
Actual: empty list.
Able to reproduce it. I think the mistake is that the "XX days" links are trying to be too smart for their own good.
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
Attached file Github PR (obsolete) —
CC'ing Adrian since he's been chosen to review the Github PR.
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1a60441d49846233933ef0a5206fba894dadfe34
fixes bug 948704 - date changing links should keep query string intact, r=adrian
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Steps to reproduce should be enough in comment 0.
Whiteboard: qa+
Target Milestone: --- → 71
Whiteboard: qa+ → [qa+]
Reopening:

Visiting https://crash-stats.allizom.org/report/list?range_value=14&signature=__divdi3 returns a HTTP 400 with the error message "range duration too long."
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file Github PR
Attachment #8355561 - Attachment is obsolete: true
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/33128096e7e281fa8fec6930f5445dc773d2c4a9
fixes bug 948704 - day changing links lack range unit

https://github.com/mozilla/socorro/commit/fddd4e07f89ea0e9f973068efefa4d59e661474f
Merge pull request #1774 from peterbe/bug-948704-day-changing-links-lack-range-unit

fixes bug 948704 - day changing links lack range unit
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Sorry; reopening this still appears to be failing on dev and stage still
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Steps to reproduce that it is working:

1. Make sure you're not signed in
2. Go to https://crash-stats.allizom.org/report/list?signature=__divdi3
3. Click "14 days"
4. Expected the URL to become: https://crash-stats.allizom.org/report/list?range_unit=days&range_value=14&signature=__divdi3
5. Works?
Thanks peterbe.

Bumping to resolved per comment 10
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
QA verified on stage using top crasher links. Data is present and url updates with the correct range_value
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: