948704 - Changing the date range via the 14 days, 28 days, etc.. ends up emptying the list

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. go to https://crash-stats.mozilla.com/report/list?signature=__divdi3
2. click on 14 days 
3. click on reports

Expected: reports.
Actual: empty list.

Comment 1

[Peter Bengtsson [:peterbe]]

Able to reproduce it. I think the mistake is that the "XX days" links are trying to be too smart for their own good.

Comment 2

[Peter Bengtsson [:peterbe]]

Attachment: Github PR

Comment 3

[Peter Bengtsson [:peterbe]]

CC'ing Adrian since he's been chosen to review the Github PR.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1a60441d49846233933ef0a5206fba894dadfe34
fixes bug 948704 - date changing links should keep query string intact, r=adrian

Comment 5

[Peter Bengtsson [:peterbe]]

Steps to reproduce should be enough in comment 0.

Comment 6

[Matt Brandt [:mbrandt]]

Reopening:

Visiting https://crash-stats.allizom.org/report/list?range_value=14&signature=__divdi3 returns a HTTP 400 with the error message "range duration too long."

Comment 7

[Peter Bengtsson [:peterbe]]

Attachment: Github PR

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/33128096e7e281fa8fec6930f5445dc773d2c4a9
fixes bug 948704 - day changing links lack range unit

https://github.com/mozilla/socorro/commit/fddd4e07f89ea0e9f973068efefa4d59e661474f
Merge pull request #1774 from peterbe/bug-948704-day-changing-links-lack-range-unit

fixes bug 948704 - day changing links lack range unit

Comment 9

[Matt Brandt [:mbrandt]]

Sorry; reopening this still appears to be failing on dev and stage still

Comment 10

[Peter Bengtsson [:peterbe]]

Steps to reproduce that it is working:

1. Make sure you're not signed in
2. Go to https://crash-stats.allizom.org/report/list?signature=__divdi3
3. Click "14 days"
4. Expected the URL to become: https://crash-stats.allizom.org/report/list?range_unit=days&range_value=14&signature=__divdi3
5. Works?

Comment 11

[Matt Brandt [:mbrandt]]

Thanks peterbe.

Bumping to resolved per comment 10

Comment 12

[Matt Brandt [:mbrandt]]

QA verified on stage using top crasher links. Data is present and url updates with the correct range_value