Closed
Bug 948716
Opened 11 years ago
Closed 11 years ago
rm TestAreKnownDOMTypes
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: efaust, Assigned: efaust)
References
Details
Attachments
(1 file)
|
2.05 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
It looks like we forgot to replace a site of type testing with TemporaryTypeSet::isDOMClass(), and, boy, is that scary. There's no good reason for methods to do a different check from accessors.
Attachment #8345599 -
Flags: review?(sstangl)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8345599 [details] [diff] [review] rmTestAreKnownDOMTypes.patch Review of attachment 8345599 [details] [diff] [review]: ----------------------------------------------------------------- Needs testcase. That was joke.
Attachment #8345599 -
Flags: review?(sstangl) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9de6643e665f
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9de6643e665f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•