Closed Bug 948728 Opened 12 years ago Closed 12 years ago

Remote debugging is bypassed for OEM build : US-V1.2-Dev-20131209.cfg

Categories

(Firefox OS Graveyard :: Vendcom, defect)

Product:
Firefox OS Graveyard
Component:
Vendcom
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: nhirata, Unassigned)

Details

1. flash US-V1.2-Dev-20131209.cfg OEM build 2. make sure remote debugging is turned off in the dev settings ( settings -> device info -> more info -> developer -> show remote debugging ) 3. attempt to adb Expected: device is not found Actual: device is found and gives unique device id Note: 1. this is a security issue. I flashed a production version of a build I made with the blobs from the OEM build and it bypasses the remote debugging.
If this is an engineering build, this is working as expected. Engineering builds aren't secure.
The previous version, which was an engineering build, did allow for the checkmark to toggle on/off adb.
Regardless, we should verify that the production build has a functioning remote debugging on/off setting.
If marionette is included in the build, then adb is forced to be always on (since marionette relies on adb) and the remote debugging checkbox doesn't control adb. By default, marionette is enabled for VARIANT=eng and VARIANT=userdebug builds, but not for VARIANT=user builds.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
adb shell getprop ro.build.type eng Closed the bug as invalid based on comment 4
I made a build using VARIANT=USER and a make production so that I don't have marionette installed and I still have adb access without the Remote Debugging enabled. root@android:/ # ps USER PID PPID VSIZE RSS WCHAN PC NAME root 1 0 428 288 c01766f4 00008728 S /init root 2 0 0 0 c00e95b8 00000000 S kthreadd root 3 2 0 0 c00d26c4 00000000 S ksoftirqd/0 root 6 2 0 0 c010b838 00000000 S migration/0 root 7 2 0 0 c00e54fc 00000000 S khelper root 8 2 0 0 c00e54fc 00000000 S suspend_sys_syn root 9 2 0 0 c00e54fc 00000000 S suspend root 10 2 0 0 c0148dc8 00000000 S sync_supers root 11 2 0 0 c0149dd8 00000000 S bdi-default root 12 2 0 0 c00e54fc 00000000 S kblockd root 13 2 0 0 c034b064 00000000 S khubd root 14 2 0 0 c00e54fc 00000000 S l2cap root 15 2 0 0 c00e54fc 00000000 S a2mp root 16 2 0 0 c00e54fc 00000000 S modem_notifier root 17 2 0 0 c00e54fc 00000000 S smd_channel_clo root 18 2 0 0 c00e54fc 00000000 S smsm_cb_wq root 21 2 0 0 c00e54fc 00000000 S rpcrouter root 22 2 0 0 c00e54fc 00000000 S rpcrotuer_smd_x root 23 2 0 0 c006c6c8 00000000 S krpcserversd root 25 2 0 0 c00e54fc 00000000 S msm_adsp_probe root 26 2 0 0 c006b4d0 00000000 D voicememo_rpc root 27 2 0 0 c006b6c8 00000000 S kadspd root 28 2 0 0 c00e54fc 00000000 S rmt_storage root 29 2 0 0 c0141cf4 00000000 S kswapd0 root 30 2 0 0 c0198b78 00000000 S fsnotify_mark root 31 2 0 0 c00e54fc 00000000 S crypto root 43 2 0 0 c00e54fc 00000000 S mdp_dma_wq root 44 2 0 0 c00e54fc 00000000 S mdp_vsync_wq root 45 2 0 0 c00e54fc 00000000 S mdp_pipe_ctrl_w root 46 2 0 0 c00e54fc 00000000 S k_hsuart root 48 2 0 0 c00e54fc 00000000 S kgsl-3d0 root 49 2 0 0 c010cd28 00000000 S irq/273-1-0039 root 50 2 0 0 c032e318 00000000 S mtdblock0 root 51 2 0 0 c032e318 00000000 S mtdblock1 root 52 2 0 0 c032e318 00000000 S mtdblock2 root 53 2 0 0 c032e318 00000000 S mtdblock3 root 54 2 0 0 c032e318 00000000 S mtdblock4 root 55 2 0 0 c032e318 00000000 S mtdblock5 root 56 2 0 0 c032e318 00000000 S mtdblock6 root 57 2 0 0 c032e318 00000000 S mtdblock7 root 58 2 0 0 c032e318 00000000 S mtdblock8 root 59 2 0 0 c032e318 00000000 S mtdblock9 root 60 2 0 0 c032e318 00000000 S mtdblock10 root 61 2 0 0 c032e318 00000000 S mtdblock11 root 62 2 0 0 c032e318 00000000 S mtdblock12 root 63 2 0 0 c032e318 00000000 S mtdblock13 root 64 2 0 0 c032e318 00000000 S mtdblock14 root 65 2 0 0 c032e318 00000000 S mtdblock15 root 66 2 0 0 c032e318 00000000 S mtdblock16 root 67 2 0 0 c032e318 00000000 S mtdblock17 root 68 2 0 0 c032e318 00000000 S mtdblock18 root 69 2 0 0 c032e318 00000000 S mtdblock19 root 70 2 0 0 c032e318 00000000 S mtdblock20 root 71 2 0 0 c032e318 00000000 S mtdblock21 root 72 2 0 0 c032e318 00000000 S mtdblock22 root 73 2 0 0 c032e318 00000000 S mtdblock23 root 74 2 0 0 c00e54fc 00000000 S k_rmnet_mux_wor root 75 2 0 0 c00e54fc 00000000 S f_mtp root 76 2 0 0 c038e538 00000000 S file-storage root 78 2 0 0 c00e54fc 00000000 S uether root 79 2 0 0 c00e54fc 00000000 S diag_wq root 80 2 0 0 c00e54fc 00000000 S diag_cntl_wq root 81 2 0 0 c010cd28 00000000 S irq/304-ft5x06_ root 82 2 0 0 c006b4d0 00000000 D krtcclntd root 83 2 0 0 c006dc8c 00000000 D krtcclntcbd root 84 2 0 0 c00e54fc 00000000 S kfmradio root 85 2 0 0 c006b4d0 00000000 D kbatteryclntd root 86 2 0 0 c006dc8c 00000000 D kbatteryclntcbd root 87 2 0 0 c00e54fc 00000000 S battery_queue root 88 2 0 0 c00e54fc 00000000 S msm_adc root 89 2 0 0 c00e54fc 00000000 S dalrpc_rcv_DAL0 root 90 2 0 0 c00e54fc 00000000 S iewq root 91 2 0 0 c00e9528 00000000 D kinteractiveup root 92 2 0 0 c00e54fc 00000000 S binder root 94 2 0 0 c0593d2c 00000000 S krfcommd root 95 2 0 0 c00e54fc 00000000 S msm-cpufreq root 96 2 0 0 c006b4d0 00000000 D khsclntd root 97 2 0 0 c00e54fc 00000000 S deferwq root 98 1 312 4 c01766f4 00008728 S /sbin/ueventd root 99 2 0 0 c04317b0 00000000 S mmcqd/0 root 100 2 0 0 c023478c 00000000 S yaffs-bg-1 root 102 2 0 0 c023478c 00000000 S yaffs-bg-1 root 103 2 0 0 c023478c 00000000 S yaffs-bg-1 root 104 2 0 0 c023478c 00000000 S yaffs-bg-1 system 128 1 852 112 c044861c 4008c8b0 S /system/bin/servicemanager root 129 1 4036 252 ffffffff 4004feb4 S /system/bin/vold root 132 1 3336 268 ffffffff 400518b0 S /system/bin/fakeperm root 134 1 7852 432 ffffffff 40102eb4 S /system/bin/netd root 135 1 720 56 c04824e0 4002b1b8 S /system/bin/debuggerd radio 136 1 20372 2344 ffffffff ffff0520 S /system/bin/rild media 137 1 22400 2228 ffffffff 4008b8b0 S /system/bin/mediaserver bluetooth 138 1 1352 108 c01766f4 ffff0520 S /system/bin/dbus-daemon keystore 139 1 1748 140 c04824e0 400bb1b8 S /system/bin/keystore system 152 1 1924 92 ffffffff 400ba0e8 S /system/bin/mm-pp-daemon system 157 1 3120 432 c01766f4 400f267c S /system/bin/mm-qcamera-daemon root 158 1 1188 164 c01766f4 4004b67c S /system/bin/gpu_dcvsd root 159 1 4484 188 ffffffff 0000829c S /sbin/adbd root 189 1 896 300 c01766f4 4004a9d4 S /system/bin/location-mq radio 190 1 6032 360 ffffffff 400b49d4 S /system/bin/qmuxd shell 193 1 792 104 c02bf6c8 40059678 S /system/bin/sh root 202 1 14936 576 ffffffff 400ed810 S /system/bin/xtwifi-inet-agent radio 203 1 6196 596 ffffffff 400c5810 S /system/bin/netmgrd root 209 1 12512 776 ffffffff 40059810 S /system/bin/xtwifi-client root 214 2 0 0 c00e54fc 00000000 S k_gserial root 217 2 0 0 c00e54fc 00000000 S k_gsmd root 219 2 0 0 c00e54fc 00000000 S k_rmnet_work root 366 2 0 0 c00e54fc 00000000 S cfg80211 root 368 2 0 0 c00e54fc 00000000 S ath6kl root 373 2 0 0 c042d884 00000000 S ksdioirqd/mmc1 system 407 1 1348 224 c01766f4 4007167c S /system/bin/qosmgr root 630 2 0 0 c006b4d0 00000000 D audmgr_rpc root 3439 2 0 0 c00e3d38 00000000 S kworker/0:1 root 4203 2 0 0 c006a038 00000000 D kworker/u:3 root 4306 2 0 0 c00e3d38 00000000 S kworker/u:2 root 4337 2 0 0 c00e3d38 00000000 S kworker/0:0 root 4562 2 0 0 c00e3d38 00000000 S kworker/u:1 root 4855 2 0 0 c00e3d38 00000000 S kworker/0:2 root 4859 2 0 0 c00e3d38 00000000 S kworker/u:0 root 4861 2 0 0 c0188930 00000000 S flush-31:5 root 4872 2 0 0 c0188930 00000000 S flush-31:6 root 4873 2 0 0 c0188930 00000000 S flush-31:2 root 4874 2 0 0 c0188930 00000000 S flush-179:0 root 4876 2 0 0 c00e3d38 00000000 S kworker/0:3 root 5207 1 181044 70668 ffffffff 40023604 S /system/b2g/b2g root 5241 5207 51056 21232 ffffffff 40149604 S /system/b2g/plugin-container log 5258 1 704 232 c02bf6c8 400c0678 S /system/bin/logwrapper wifi 5259 5258 2680 1460 c01766f4 400669d4 S /system/bin/wpa_supplicant app_5275 5275 5207 85924 39432 ffffffff 4010c604 S /system/b2g/plugin-container app_5276 5276 5207 90540 35032 ffffffff 4003f604 S /system/b2g/plugin-container root 5343 5241 60264 19148 ffffffff 40149604 S /system/b2g/plugin-container root 5352 5241 60264 19152 ffffffff 40149604 S /system/b2g/plugin-container root 5372 159 796 440 c0046254 40036094 S /system/bin/sh root 5382 5372 972 288 00000000 4008b678 R ps root@android:/ # APPLICATION USER PID PPID VSIZE RSS WCHAN PC NAME b2g root 5207 1 179948 70512 ffffffff 40023604 S /system/b2g/b2g (Nuwa) root 5241 5207 51056 21232 ffffffff 40149604 S /system/b2g/plugin-container Communications app_5275 5275 5207 77380 36432 ffffffff 4010c604 S /system/b2g/plugin-container Homescreen app_5276 5276 5207 74720 32560 ffffffff 4003f604 S /system/b2g/plugin-container (Preallocated a root 5343 5241 59240 19144 ffffffff 40149604 S /system/b2g/plugin-container (Preallocated a root 5352 5241 59240 19148 ffffffff 40149604 S /system/b2g/plugin-container root@android:/ #
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
When you made the VARIANT=user build, did you rm -rf out and objdir-gecko? Could you attach the output of logcat from booting up the phone?
Which branch did you build? Is this for a Buri? I'll try to see if I can reproduce the problem.
Oh nuts. I didn't rm -rf out and objdir-gecko I placed on the releng builds and the settings does work as expected. Since the Releng production builds work correctly, I'm invalidating this again.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.