948753 - Annotate sane nsISupports virtual methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

There are some calls like nsISupports::GetCurrentJSContext that theoretically could be overridden with something that can GC, but really won't be in practical terms.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Annotate sane nsISupports virtual methods

This patch adds a way to say, "while *most* virtual methods on nsISupports subclasses could do be overridden with something crazy, this particular one won't be". This allows the analysis to treat it like any other virtual method and find all implementations of that virtual. This is a relatively safe annotation, since if someone happens to override it later with something that can GC, the analysis will see it.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 8345625 [details] [diff] [review]
Annotate sane nsISupports virtual methods

Review of attachment 8345625 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/devtools/rootAnalysis/computeCallgraph.js
@@ +281,2 @@
>      for (var body of functionBodies)
> +        processBody(functionName, body);

This seems unrelated to the rest of the patch.

Comment 3

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c936908a2fa

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c936908a2fa