Closed Bug 948769 Opened 6 years ago Closed 6 years ago
[Settings][DSDS] Default service ID should be a number
Gecko expects a number for default service IDs. Although it also works with strings, but we should use the same type across apps (system, settings, messaging).
6 years ago
Assignee: nobody → ejchen
Hi Arthur, I just got green from Travis about this patch. It is really a small patch changing some values in build/settings.js from String to Number. Please help me take a look at it when you have time. Thanks ;)
Attachment #8346303 - Flags: review?(arthur.chen)
Comment on attachment 8346303 [details] [review] patch on github r=me. Thanks!
Attachment #8346303 - Flags: review?(arthur.chen) → review+
Thanks Arthur ! This patch was landed on Gaia/master : dc063ebf9efe13e341dda2b4d93da7fd34d8d4d4.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Hi Joe, we will need this fixing for v1.3 DSDS feature, or it might cause some other problems while sim switch.
blocking-b2g: --- → 1.3?
1.3+ for DSDS
blocking-b2g: 1.3? → 1.3+
Uplifted dc063ebf9efe13e341dda2b4d93da7fd34d8d4d4 to: v1.3: 0f6a4f79ff151e43f7c3fa4aa172af18c3e82c88
You need to log in before you can comment on or make changes to this bug.