948769 - [Settings][DSDS] Default service ID should be a number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Gecko expects a number for default service IDs. Although it also works with strings, but we should use the same type across apps (system, settings, messaging).

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on github

Hi Arthur, 

I just got green from Travis about this patch. It is really a small patch changing some values in build/settings.js from String to Number.

Please help me take a look at it when you have time. Thanks ;)

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8346303 [details] [review]
patch on github

r=me. Thanks!

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur !

This patch was landed on Gaia/master : dc063ebf9efe13e341dda2b4d93da7fd34d8d4d4.

Comment 4

[Steve Chung [:steveck]]

Hi Joe, we will need this fixing for v1.3 DSDS feature, or it might cause some other problems while sim switch.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

1.3+ for DSDS

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted dc063ebf9efe13e341dda2b4d93da7fd34d8d4d4 to:
v1.3: 0f6a4f79ff151e43f7c3fa4aa172af18c3e82c88