948782 - make test_alerts_noobserve.html wait until its alerts have disappeared before finishing

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

I've had some issues with test_multiple_alerts.html failing with this error (on try runs, with my patch queue applied):

157682 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/alerts/test/test_multiple_alerts.html | Second alert should be opened in the same position. - got 32, expected 33

After adding some debugging, it looks like the previous test, test_alerts_noobserve.html, leaves notification visible when it finishes and advances to the next test, and that the previous notification can cause the position of one of the notifications from test_multiple_alerts.html to be placed differently.  I think it would be best if test_alerts_noobserve.html waited at the end until the notification disappears naturally (still without adding an observer, which is what the test is testing).

Comment 1

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=585cbd490627

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8345669 [details]
patch

More work required it seems.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch v2

This seemed to work better, also adding in some waiting for notifications to disappear in test_multiple_alerts.html.

https://tbpl.mozilla.org/?tree=Try&rev=cc71827ac1d5

Comment 4

[Cameron McCormack (:heycam)]

Attachment: patch v2.1

Sorry one final tweak.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: patch v3

From IRC conversations, the theory is that test_alerts_noobserve.html might have its alert start showing only after that test has finished.  So in this patch we wait a bit at the end of the test, before checking whether the alert has disappeared.  This make it no longer necessary to wait for alerts to disappear in test_multiple_alerts.html, though I've included a test that there aren't any, at the beginning of the test.

https://tbpl.mozilla.org/?tree=Try&rev=c1e42e85d12c

Comment 6

[William Chen [:wchen]]

Comment on attachment 8346287 [details] [diff] [review]
patch v3

Review of attachment 8346287 [details] [diff] [review]:
-----------------------------------------------------------------

test_alerts_noobserve.html certainly wasn't cleaning up after itself before. The logs show that it is now waiting for the alert window to close before finishing.

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8344fa6ecea6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8344fa6ecea6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9c7bc5a8c724