Closed Bug 948798 Opened 10 years ago Closed 10 years ago

[Cost Control] After reset Wifi usage, the usage does not be reset.

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

RESOLVED FIXED
1.3 C2/1.4 S2(17jan)
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: askeing, Assigned: mai)

Details

(Keywords: regression, Whiteboard: [xfail])

Attachments

(2 files)

Attached video VID_0006.3gp
### ENV
Buri
Gaia      552c6661aa4549ae62d660d220e893db39a8a320
Gecko     http://hg.mozilla.org/mozilla-central/rev/3ea3d3baa67b
BuildID   20131210191148
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818

### STR
0. flash gaia/gecko into the phone.
1. launch Usage app (1st), disable Mobile usage and enable Wifi usage.
2. launch Settings app, enable Wifi and connect to AP.
3. launch Browser app, access any website.
4. launch Settings app, disable Wifi.
5. launch Usage app (2nd).
6. tap gear button to open settings page of Usage app.
7. tap "Reset" button, then tap "Reset wifi usage" button.
8. tap "Done" button to return to the main page of Usage app.

### Expected
1. launch Usage app (1st), after enable Wifi usage, the Wifi usage should be 0.00 B.
2. launch Usage app (2nd), the Wifi usage should be larger than 0.00 B.
3. after tap "Reset wifi usage" button, the Wifi usage in Settings page should be 0.00 B.
4. after tap "Reset wifi usage" button then tap "Done" button, the Wifi usage in main page should be 0.00 B.

### Actual
1. as expected
2. as expected
3. as expected
4. after tap "Reset wifi usage" then tap "Done" button, the Wifi usage in main page is not 0.00 B.
blocking-b2g: --- → 1.3?
Whiteboard: [xfail]
QA Contact: sparsons
This issue started to occur on the Buri 1.3 Build ID: 20131126052050

Gaia   4ad796b196d468bdb231beba4392acbc90a74e96
SourceStamp 99479edbee2a
BuildID 20131126052050
Version 28.0a1

Last working Buri 1.3 Build ID: 20131125142741

Gaia   bd8053d30c275f8d3040cd494e04b3480a784656
SourceStamp 757c2011df5b
BuildID 20131125142741
Version 28.0a1
On the Gaia side, the only patch that's suspicious for causing this is bug 937244.
Ok, it seems a very easy bug related with not refreshing the updated information after exit the settings.
Assignee: nobody → mri
Attached file patch v1.0
Please, could you review the code?
Regards
Attachment #8347098 - Flags: review?(salva)
Comment on attachment 8347098 [details]
patch v1.0

Please, review my comments on GitHub.
Attachment #8347098 - Flags: review?(salva) → review-
Comment on attachment 8347098 [details]
patch v1.0

Please, could you review the patch?
Regards
Attachment #8347098 - Flags: review- → review?(salva)
Comment on attachment 8347098 [details]
patch v1.0

Solution is not bad but please, attend my comments on GitHub. Thank you.
Attachment #8347098 - Flags: review?(salva)
triage: 1.3+ regrsesion
blocking-b2g: 1.3? → 1.3+
Comment on attachment 8347098 [details]
patch v1.0

Please, could your review the code?

Regards
Attachment #8347098 - Flags: review?(salva)
Comment on attachment 8347098 [details]
patch v1.0

You have the r+ once the couple of nits in the code have been solved.

Thank you Marina!
Attachment #8347098 - Flags: review?(salva) → review+
Updated the code with your comments Salva. 

Regards
salva - are we good to land this then? We need landed asap, as this is blocking UI automation right now.
Flags: needinfo?(salva)
Master: 0a682dc32194b4f66a811f6cd2dbe423458bfb99

I'm on vacation right now ,)
Happy new year.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(salva)
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
### ENV
Buri pvt m-c build
Gaia      711d8bf4efde6b1aaaf1f61bd422312c17435810
Gecko     http://hg.mozilla.org/mozilla-central/rev/cf80c0d4f46e
BuildID   20140105040201
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

### STR
1. launch Usage app (1st), disable Mobile usage, and enable Wifi usage.
2. enable Wifi and connect to AP.
3. launch Browser app, access any website.
4. disable Wifi.
5. launch Usage app (2nd).
6. tap gear button to open settings page of Usage app.
7. tap "Reset" button, then tap "Reset wifi usage" button.
8. tap "Done" button to return to the main page of Usage app.

### Expected
after tap "Reset wifi usage" button then tap "Done" button, the Wifi usage in main page should be 0.00 B.

### Actual
after tap "Reset wifi usage" then tap "Done" button, the Wifi usage is not 0.00 B.

### Note
if we add a step, "4.1 after disable wifi, then wait more than 5 seconds before launch Usage app (2nd)", then we can get the expected result.

It will fail when we disable wifi, then launch usage app quickly.
And it will pass when we disable wifi, wait a moment to make sure all wifi actions are done, then launch usage app.
(In reply to Askeing Yen[:askeing] from comment #14)
> ### ENV
> Buri pvt m-c build
> Gaia      711d8bf4efde6b1aaaf1f61bd422312c17435810
> Gecko     http://hg.mozilla.org/mozilla-central/rev/cf80c0d4f46e
> BuildID   20140105040201
> Version   29.0a1
> ro.build.version.incremental=eng.archermind.20131114.105818
> ro.build.date=Thu Nov 14 10:58:33 CST 2013
> 
> ### STR
> 1. launch Usage app (1st), disable Mobile usage, and enable Wifi usage.
> 2. enable Wifi and connect to AP.
> 3. launch Browser app, access any website.
> 4. disable Wifi.
> 5. launch Usage app (2nd).
> 6. tap gear button to open settings page of Usage app.
> 7. tap "Reset" button, then tap "Reset wifi usage" button.
> 8. tap "Done" button to return to the main page of Usage app.
> 
> ### Expected
> after tap "Reset wifi usage" button then tap "Done" button, the Wifi usage
> in main page should be 0.00 B.
> 
> ### Actual
> after tap "Reset wifi usage" then tap "Done" button, the Wifi usage is not
> 0.00 B.
> 
> ### Note
> if we add a step, "4.1 after disable wifi, then wait more than 5 seconds
> before launch Usage app (2nd)", then we can get the expected result.
> 
> It will fail when we disable wifi, then launch usage app quickly.
> And it will pass when we disable wifi, wait a moment to make sure all wifi
> actions are done, then launch usage app.

Hi Salva,

It seems like when we launch usage app quickly, the wifi still have some actions after usage app be launched. And that wifi usage is not updated on usage app.
I'm not sure is it satisfiable for user.
If we want to fix this issue, I'll suggest to update usage data after tap "Reset" button and before do reset action.

Could you please help to provide us your idea?
Thank you.
Flags: needinfo?(salva)
Uplifted 0a682dc32194b4f66a811f6cd2dbe423458bfb99 to:
v1.3: dc9a676176f48922840150ccf75c857a7152ee63
Hello Askeing

If the problem is as you think, please, let's open another bug to track it as it is not related with this one. According to your words I suppose when you tap on 'Reset wi-fi' there is some few bytes in the meter result of switching down the interface.

I don't see a problem here. To double reset the wi-fi data is not a warranty to see 0.00 and it is true we are performing a reset just counting after that point. Indeed, you have concluded switching off is not an immediate task and some information is traded thanks to the information displayed in the Usage application after resetting. It is just a side effect and I won't advocate to fake the 0.00B

What do you think?
Flags: needinfo?(salva)
Thanks for your information, I agree with your opinion :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: