948833 - xpcom/base/nsMemoryReporterManager.cpp:225:23: error: no member named 'max' in namespace 'std'

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jan Beich]

I've locally backported bug 945046 to ff27 only to end up bumping into a header bootlegging: <algorithm> via PMemoryReportRequestParent.h.

xpcom/base/nsMemoryReporterManager.cpp:225:23: error:
      no member named 'max' in namespace 'std'; did you mean 'mtx'?
            *maxreg = std::max(*maxreg,
                      ^~~~~
/usr/include/sys/_mutex.h:45:8: note: 'mtx' declared here
struct mtx {
       ^
1 error generated.

Comment 1

[Jan Beich]

Attachment: explicit #include

Comment 2

[Jan Beich]

Comment on attachment 8345728 [details] [diff] [review]
explicit #include

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 945046
User impact if declined: none, only style
Risk to taking this patch (and alternatives if risky): NPOTB

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7b9dc991a45

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7b9dc991a45

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8345728 [details] [diff] [review]
explicit #include

a=NPTOB, no need for approval on NPTOB patches.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fdd56ee33359