948855 - [fugu][dolphin][Browser] keep pressing tab badge continuously will make device hang for a period of time

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[viral [:viralwang]]

reproduce steps:
1. open browser
2. keep pressing tab badge continuously (like 30+ clicks)

Device will stuck for a while.
(Partner found this issue in monkey test)

We found lots of tabs will create and consume lots of memory.
It costs some time to wait for LMK works fine, device looks hang in this period and no response until it recovers.

Comment 1

[viral [:viralwang]]

Attachment: this patch will help release memory pressure should improve this bug

Comment 2

[James Zhang (Spreadtrum)]

Who will review this patch?

Comment 3

[Keven Kuo [:kkuo]]

Hi! Alan,

Could you help to review? It is fugu only.

--
Keven

Comment 4

[viral [:viralwang]]

Attachment: bug948855

Comment 5

[Alan Huang]

Comment on attachment 8349307 [details] [diff] [review]
bug948855

This is actually 
https://git.mozilla.org/?p=releases/gecko.git;a=commit;h=f36c0848bbd91eb9373933ae4077c64133ce418c
https://git.mozilla.org/?p=releases/gecko.git;a=commit;h=8caf4f9ee0b5b96967d678cd2c17ed2707b61010
and https://bug948828.bugzilla.mozilla.org/attachment.cgi?id=8345791

This first two are already landed. The third one is still under review, but I would give it a feedback+ since I'm owner of that patch :p

This is a workaround to kill background processes out of a hard limit. I think it is okay to land on 1.2f. 

We should focus on bug 948370 to get a solution to land on 1.4 or 1.3. I believe that's a bug could fixed by gaia.

Comment 6

[James Zhang (Spreadtrum)]

Ying, should we merge this patch into v1.3T?

Comment 7

[bhavana bajaj [:bajaj]]

(In reply to James Zhang from comment #6)
> Ying, should we merge this patch into v1.3T?

In triage we didn't think this was a realistic scenario to block a release on, we can consider uplift on 1.3T if needed once all the patches have landed and resolved on master.

Comment 8

[ying.xu]

(In reply to James Zhang from comment #6)
> Ying, should we merge this patch into v1.3T?

I think no.
The browser app is not OOP now.So the LMK/killhard can't kill it.

Comment 9

[BMO Automation]

Firefox OS is not being worked on